[juniper] Removing last trunk member errors out #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -495,3 +500,9 @@ def get_or_create_interface(if_list, port): | |||
|
|
|||
| return existing | |||
|
|
|||
|
|
|||
| def port_is_in_access_mode(port): | |||
| return port.mode is None or port.mode == "access" | |||
There was a problem hiding this comment.
What are the conditions to have port.mode == None?
There was a problem hiding this comment.
|
👍 |
|
👎 tests are failing |
|
They all passed on my machine :( Looks like the order is important in the XML (yeah right)... Trying to reproduce locally. |
c0aaab1 to
cc2402a
Compare
| @@ -335,19 +335,19 @@ def apply_trunk_native_vlan(self, interface_data, port): | |||
| def get_trunk_native_vlan_node(self, interface_node): | |||
| return interface_node.xpath("unit/family/ethernet-switching/native-vlan-id") | |||
|
|
|||
| @staticmethod | |||
There was a problem hiding this comment.
i mean why static?
I get the "it doesn't use self" argument, but philsophilcally, it does not act on the class, of the instances but rather a a simple extraction of an instance method, i don't think that qualifies it to be static. and maybe it's also worth being _underscored as a protected method
|
LGTM 👍 |
|
👎 just in case i wasn't clear |
cc2402a to
1af706d
Compare
|
Alright, addressed latest comments in last push. |
1af706d to
eeaff03
Compare
|
👍 |
emmurd
added a commit
that referenced
this pull request
Mar 2, 2016
…ember [juniper] Removing last trunk member errors out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the last trunk member of a trunk interface results
in an error at commit time.