Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(open-payments): generateJwk #788

Merged
merged 1 commit into from
Nov 28, 2022
Merged

feat(open-payments): generateJwk #788

merged 1 commit into from
Nov 28, 2022

Conversation

mkurapov
Copy link
Contributor

@mkurapov mkurapov commented Nov 25, 2022 •
edited
Loading

Changes proposed in this pull request

  • Adding generateJwk function to open-payments package, to generate JWKs from given/generated key with the correct format & type for Open Payments API

Context

Initially, this was supposed to be used in the MAP for seeding:
#786 (comment)
but for now, just placing this in here for any consumers to use, like @wilsonianb 's PR: https://github.com/interledger/rafiki/pull/779/files

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass

@github-actions github-actions bot added pkg: open-payments type: source Changes business logic type: tests Testing related labels Nov 25, 2022
@mkurapov mkurapov requested a review from wilsonianb November 25, 2022 01:04
@mkurapov mkurapov merged commit 48cdfa2 into main Nov 28, 2022
@mkurapov mkurapov deleted the 663/mk/generate-jwk branch November 28, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilsonianb wilsonianb wilsonianb approved these changes

Assignees
No one assigned
Labels
type: source Changes business logic type: tests Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkurapov @wilsonianb