Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: accept peering request #1849

Merged
merged 90 commits into from
Sep 19, 2023
Merged

feat: accept peering request #1849

merged 90 commits into from
Sep 19, 2023

Conversation

mkurapov
Copy link
Contributor

@mkurapov mkurapov commented Sep 11, 2023 •
edited
Loading

Changes proposed in this pull request

  • Add POST / handler for auto-peering, which:
    • validates the incoming request
    • creates the requested peer locally
    • returns its own peering information if successful
  • Removes GET peering details handler (to simplify service)

Context

Steps 3 & 4 of the given diagram:
image

Fixes #1802

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass
  • Postman collection updated

@BlairCurrey
feat(backend): WIP - add feeid to quote table
4f458ba
@BlairCurrey
refactor(backend): rename quote gql field
7dc1d60
@BlairCurrey
Merge branch 'main' into bc/1639/add-fees-to-quote
e39bb88
@BlairCurrey
Merge branch 'main' into bc/1639/add-fees-to-quote
35ed878
@BlairCurrey
fix(backend): add fee relation
752df9b
@BlairCurrey
feat(backend): WIP calculate fees in quote create
088058b
@BlairCurrey
refactor(backend): rename gql quote field
5cce896
@BlairCurrey
fix(backend): rm unused with graph fetched
7bc19df
@BlairCurrey
Merge branch 'main' into bc/1639/add-fees-to-quote
8383ed5
@BlairCurrey
Merge branch 'main' into bc/1639/add-fees-to-quote
a0b2c30
@BlairCurrey
feat(backend): move fee calculation to quote service
874bcf6
@BlairCurrey
fix(backend): use quote error
d58532c
@BlairCurrey
Merge branch 'main' into bc/1639/add-fees-to-quote
4026c23
@BlairCurrey
Merge branch 'main' into bc/1639/add-fees-to-quote
d4e0bdf
@BlairCurrey
fix(backend): rm unused fn
9635035
@BlairCurrey
refactor(backend): rename quote send amount value
1fd63fd
@BlairCurrey
refactor(backend): rename quote send amount to debit amount
dc88ba8
@BlairCurrey
refactor(backend): rename out payment send amount to debit
e393681
@BlairCurrey
chore(backend): format
9a09017
@BlairCurrey
chore(documentation): update gql docs
393198b
@BlairCurrey
fix(backend,localenv): trx amount
c5ea21d
@BlairCurrey
fix(backend): handle cross currency fee in quote
46cb2cd
@BlairCurrey
Merge branch 'main' into bc/1639/add-fees-to-quote
28f096a
@BlairCurrey
refactor: update spec and rename more fields
4c3ae8e
@BlairCurrey
fix(backend): outgoing limit test
93a0da7
@BlairCurrey
refactor(backend): rename limits field
4904216
@BlairCurrey
rename sendAmount to debitAmount
198b4ea
@BlairCurrey
fix(localenv): postman ecommerce flow
44e2884
@BlairCurrey
Merge branch 'main' into bc/1639/add-fees-to-quote
75b328a
@BlairCurrey
fix(backend): remove useless checks
56bd689
@github-actions github-actions bot added pkg: mock-ase pkg: documentation Changes in the documentation package. type: documentation (archived) Improvements or additions to documentation labels Sep 14, 2023
@github-actions github-actions bot added type: ci Changes to the CI and removed pkg: mock-ase pkg: documentation Changes in the documentation package. type: documentation (archived) Improvements or additions to documentation labels Sep 14, 2023
@github-actions github-actions bot removed the type: ci Changes to the CI label Sep 14, 2023
@github-actions github-actions bot removed pkg: frontend Changes in the frontend package. pkg: auth Changes in the GNAP auth package. labels Sep 14, 2023
@mkurapov
Copy link
Contributor Author

I merged in Blair's changes before it was merged into main, hence the many commits here

@mkurapov mkurapov merged commit c9c047e into main Sep 19, 2023
@mkurapov mkurapov deleted the mk/1802/accept-peering-request branch September 19, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlairCurrey BlairCurrey BlairCurrey left review comments

@raducristianpopa raducristianpopa raducristianpopa approved these changes

@dragosp1011 dragosp1011 dragosp1011 approved these changes

@njlie njlie njlie left review comments

@sabineschaller sabineschaller Awaiting requested review from sabineschaller

Assignees
No one assigned
Labels
pkg: backend Changes in the backend package. type: source Changes business logic type: tests Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add POST /peer route handler
5 participants
@mkurapov @raducristianpopa @BlairCurrey @njlie @dragosp1011