Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(backend): implement bigint toJSON #140

Merged
merged 1 commit into from
Oct 6, 2021
Merged

chore(backend): implement bigint toJSON #140

merged 1 commit into from
Oct 6, 2021

Conversation

wilsonianb
Copy link
Contributor

@wilsonianb wilsonianb commented Oct 6, 2021 •
edited
Loading

Changes proposed in this pull request

This is also already happening in the GraphQLBigInt custom scalar:
https://github.com/interledger/rafiki/blob/main/packages/backend/src/graphql/scalars/BigInt.ts#L17-L23

Context

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass

@wilsonianb
chore(backend): implement bigint toJSON
3d056da 
This allows objects with bigints to be serialized by loggers.
@github-actions github-actions bot added pkg: backend Changes in the backend package. type: source Changes business logic labels Oct 6, 2021
@wilsonianb wilsonianb marked this pull request as ready for review October 6, 2021 18:54
@wilsonianb wilsonianb merged commit 99673dc into main Oct 6, 2021
@wilsonianb wilsonianb deleted the bw-bigint-tojson branch October 6, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentientwaffle sentientwaffle sentientwaffle approved these changes

@sharafian sharafian Awaiting requested review from sharafian

@cairin cairin Awaiting requested review from cairin

@matdehaast matdehaast Awaiting requested review from matdehaast

Assignees
No one assigned
Labels
pkg: backend Changes in the backend package. type: source Changes business logic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jest expect failure error with BigInt Audit BigInt logging
2 participants
@wilsonianb @sentientwaffle