Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Admin APIs #1192

Merged
merged 8 commits into from
Mar 13, 2023
Merged

docs: Admin APIs #1192

merged 8 commits into from
Mar 13, 2023

Conversation

sabineschaller
Copy link
Member

@sabineschaller sabineschaller commented Mar 6, 2023 •
edited
Loading

Changes proposed in this pull request

  • add docs to backend graphql.schema
  • add docs to auth graphql.schema

Context

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass

@github-actions github-actions bot added pkg: backend Changes in the backend package. pkg: map Changes in mock-account-provider package type: source Changes business logic labels Mar 6, 2023
@github-actions github-actions bot added the pkg: auth Changes in the GNAP auth package. label Mar 8, 2023
@sabineschaller sabineschaller marked this pull request as ready for review March 8, 2023 09:53
wilsonianb
wilsonianb reviewed Mar 9, 2023
View reviewed changes
mkurapov
mkurapov approved these changes Mar 13, 2023
View reviewed changes
packages/auth/src/grant/model.ts
Comment on lines +20 to +23
Pending = 'PENDING',
Granted = 'GRANTED',
Revoked = 'REVOKED',
Rejected = 'REJECTED'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking we should edit 20220504161932_create_grants_table migration to change state to be an enum but there are more places that are guilty of this, so we can hold off for now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we stop being allowed to edit migrations after we tag v1?

@sabineschaller sabineschaller merged commit 8955d7e into main Mar 13, 2023
@sabineschaller sabineschaller deleted the s2-docs-admin-api branch March 13, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurapov mkurapov mkurapov approved these changes

@AlexLakatos AlexLakatos Awaiting requested review from AlexLakatos

@raducristianpopa raducristianpopa Awaiting requested review from raducristianpopa

@wilsonianb wilsonianb Awaiting requested review from wilsonianb

Assignees
No one assigned
Labels
pkg: auth Changes in the GNAP auth package. pkg: backend Changes in the backend package. pkg: map Changes in mock-account-provider package type: source Changes business logic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document Admin APIs (backend and auth)
3 participants
@sabineschaller @wilsonianb @mkurapov