Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add shared sub-resource id path parameter #189

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

wilsonianb
Copy link
Contributor

We previously renamed sub-resource ids to incomingPaymentId, etc to disambiguate from the accompanying accountId path parameter.
accountId was removed in the switch to payment pointers, and sub-resource ids are now the lone path parameters.
This makes path parameters consistent with the auth server spec.

@wilsonianb wilsonianb marked this pull request as ready for review September 21, 2022 14:41
in: path
schema:
type: string
format: uuid
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes or no on enforcing uuid?
interledger/rafiki#603 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote no. That's a business decision.

@sabineschaller
Copy link
Member

I like the change. I'm don't like that we need to change the implementation again. But I'm sure you'll do that @wilsonianb 😉

@wilsonianb
Copy link
Contributor Author

wilsonianb commented Sep 21, 2022

I like the change. I'm don't like that we need to change the implementation again. But I'm sure you'll do that @wilsonianb wink

Yeah, I'll semi-revert this (as well as belatedly remove accountId):

@wilsonianb wilsonianb merged commit 4c873db into interledger:main Sep 22, 2022
@wilsonianb wilsonianb deleted the bw-parameters branch September 22, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants