feat: make body, interact_ref optional on client grant continue (#436)

* feat: make body, interact_ref optional on client grant continue * chore: changeset
interledger · Mar 14, 2024 · b3a5d3b · b3a5d3b
1 parent 2e318b0
commit b3a5d3b
Show file tree

Hide file tree

Showing 4 changed files with 61 additions and 18 deletions.
diff --git a/.changeset/olive-eagles-talk.md b/.changeset/olive-eagles-talk.md
@@ -0,0 +1,5 @@
+---
+'@interledger/open-payments': patch
+---
+
+Makes body and interact_ref optional on continuation route
diff --git a/packages/open-payments/src/client/grant.test.ts b/packages/open-payments/src/client/grant.test.ts
@@ -83,30 +83,68 @@ describe('grant', (): void => {
     })
 
     describe('continue', () => {
-      test('calls post method with correct validator', async (): Promise<void> => {
+      describe('calls post method with correct validator', (): void => {
         const mockResponseValidator = ({ path, method }) =>
           path === '/continue/{id}' && method === HttpMethod.POST
 
-        jest
-          .spyOn(openApi, 'createResponseValidator')
-          .mockImplementation(mockResponseValidator as any)
+        test('with interact_ref', async (): Promise<void> => {
+          jest
+            .spyOn(openApi, 'createResponseValidator')
+            .mockImplementation(mockResponseValidator as any)
+
+          const postSpy = jest.spyOn(requestors, 'post')
+          const interact_ref = uuid()
+
+          await createGrantRoutes({ openApi, client, ...deps }).continue(
+            {
+              url,
+              accessToken
+            },
+            { interact_ref }
+          )
+
+          expect(postSpy).toHaveBeenCalledWith(
+            deps,
+            { url, accessToken, body: { interact_ref } },
+            true
+          )
+        })
+        test('without interact_ref', async (): Promise<void> => {
+          jest
+            .spyOn(openApi, 'createResponseValidator')
+            .mockImplementation(mockResponseValidator as any)
+
+          const postSpy = jest.spyOn(requestors, 'post')
+          const body = {}
+
+          await createGrantRoutes({ openApi, client, ...deps }).continue(
+            {
+              url,
+              accessToken
+            },
+            body
+          )
+
+          expect(postSpy).toHaveBeenCalledWith(
+            deps,
+            { url, accessToken, body },
+            true
+          )
+        })
+        test('without body', async (): Promise<void> => {
+          jest
+            .spyOn(openApi, 'createResponseValidator')
+            .mockImplementation(mockResponseValidator as any)
 
-        const postSpy = jest.spyOn(requestors, 'post')
-        const interact_ref = uuid()
+          const postSpy = jest.spyOn(requestors, 'post')
 
-        await createGrantRoutes({ openApi, client, ...deps }).continue(
-          {
+          await createGrantRoutes({ openApi, client, ...deps }).continue({
             url,
             accessToken
-          },
-          { interact_ref }
-        )
+          })
 
-        expect(postSpy).toHaveBeenCalledWith(
-          deps,
-          { url, accessToken, body: { interact_ref } },
-          true
-        )
+          expect(postSpy).toHaveBeenCalledWith(deps, { url, accessToken }, true)
+        })
       })
     })
   })

diff --git a/packages/open-payments/src/client/grant.ts b/packages/open-payments/src/client/grant.ts
@@ -25,7 +25,7 @@ export interface GrantRoutes {
   ): Promise<PendingGrant | Grant>
   continue(
     postArgs: GrantOrTokenRequestArgs,
-    args: GrantContinuationRequest
+    args?: GrantContinuationRequest
   ): Promise<Grant | GrantContinuation>
   cancel(postArgs: GrantOrTokenRequestArgs): Promise<void>
 }

diff --git a/packages/open-payments/src/types.ts b/packages/open-payments/src/types.ts
@@ -96,7 +96,7 @@ export type GrantRequest = {
   interact?: ASOperations['post-request']['requestBody']['content']['application/json']['interact']
 }
 export type GrantContinuationRequest = {
-  interact_ref: ASOperations['post-continue']['requestBody']['content']['application/json']['interact_ref']
+  interact_ref?: ASOperations['post-continue']['requestBody']['content']['application/json']['interact_ref']
 }
 export type PendingGrant = {
   interact: ASComponents['schemas']['interact-response']