Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contacts.update.update types does not show current companies #457

Open
Jaakkonen opened this issue Jan 2, 2025 · 1 comment
Open

contacts.update.update types does not show current companies #457

Jaakkonen opened this issue Jan 2, 2025 · 1 comment

Comments

@Jaakkonen
Copy link

Jaakkonen commented Jan 2, 2025

In v5 existing attached companies were returned when updating a contact with client.contacts.update in updatedContact.companies.data. However this field is no longer present in the typescript type definitions. The API docs show that the field should be available though: Image

This seems to be a bug in the Fern product (or configuration passed to it) that you're using to generate the type definitions.

This blocks us upgrading our intercom client to v6 as a paying customer :/

@fern-support
Copy link
Collaborator

Thanks for the issue @Jaakkonen! It looks like you identified a gap in Intercom's OpenAPI spec, which Fern uses to generate their SDKs. The client.contacts.update method is configured to return a contact object, but the contact schema doesn't contain the companies property (like you've described).

We'll simply need to update the OpenAPI spec to include the missing properties and regenerate the SDK. If this is urgent for you, please feel free to opening a pull request to the 2.11 OpenAPI spec here. Otherwise, we'll confirm the expected behavior with the Intercom team and have an update for you here soon.

devin-ai-integration bot added a commit to fern-api/Intercom-OpenAPI that referenced this issue Jan 12, 2025
…nd nullable flag

This change reinforces the companies property in the Contact schema by:
- Adding descriptive metadata about the property's structure
- Explicitly marking it as nullable
- Maintaining correct reference to contact_companies schema

Addresses issue reported in intercom/intercom-node#457

Co-Authored-By: Deep Singhvi <deep@buildwithfern.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants