Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Proposition: Change UX for plugin unload in snapctl #608

Closed
pittma opened this issue Dec 8, 2015 · 3 comments
Closed

Proposition: Change UX for plugin unload in snapctl #608

pittma opened this issue Dec 8, 2015 · 3 comments
Assignees
@tiffanyfay
Labels
tracked

Comments

@pittma
Copy link
Contributor

pittma commented Dec 8, 2015

Currently, the way to unload a plugin via snapctl looks like this:

$ snapctl plugin unload -t collector -n foo -v 1

I propose just a single, positional argument:

$ snapctl plugin unload collector:foo:1

This issue arose from a discussion on #607.
@thomastaylor312
Copy link
Contributor

@danielscottt +1 on this. It has always been a royal pain to unload a plugin and it is easy to forget one of the arguments. I would also like to see what @tiffanyfj said in #607 with being able to unload all plugins of the same name, type, or version.

@tiffanyfay tiffanyfay mentioned this issue Dec 9, 2015
Merged
tiffanyfay added a commit that referenced this issue Dec 9, 2015
@tiffanyfay
Merge pull request #616 from tiffanyfj/tb/refactor
02479d7 
Fixes #608. Added snapctl t:n:v unload/config get option
@tiffanyfay
Copy link
Contributor

Fixed by #616

@tiffanyfay tiffanyfay reopened this Dec 9, 2015
@tiffanyfay
Copy link
Contributor

Accidentally reopened it since I didn't realize merging my fix closed it...

@lynxbat lynxbat added type/bug and removed type/bug labels Dec 10, 2015
@tiffanyfay tiffanyfay self-assigned this Dec 10, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tiffanyfay tiffanyfay

Labels
tracked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pittma @lynxbat @thomastaylor312 @tiffanyfay