Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Commit

Permalink
minor typos
Browse files Browse the repository at this point in the history
* Plugin was written as plugins, which was creepy because it made me think of Golem
* Typo in a comment of execution.go
  • Loading branch information
mbbroberg committed Jan 20, 2016
1 parent 381a96a commit 981426b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion control/plugin/execution.go
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ func (e *ExecutablePlugin) WaitForResponse(timeout time.Duration) (*Response, er
return r, err
}

// Private method which handles behvaior for wait for response for daemon and non-daemon modes.
// Private method which handles behavior for wait for response for daemon and non-daemon modes.
func waitHandling(p pluginExecutor, timeout time.Duration, logpath string) (*Response, error) {
log := execLogger.WithField("_block", "waitHandling")

Expand Down
4 changes: 2 additions & 2 deletions docs/PLUGIN_BEST_PRACTICES.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## Best practices in plugins development:
## Best practices in plugin development:
### Leverage plugin configurability options
1. **Compile time configuration** - use `Plugin.PluginMeta` to define plugins's: name, version, type, accepted and returned content types, concurrency level, exclusiveness, secure communication settings and cache TTL. This type of configuration is usually specified in `main()` in which `plugin.Start()` method is called.
1. **Compile time configuration** - use `Plugin.PluginMeta` to define plugin's: name, version, type, accepted and returned content types, concurrency level, exclusiveness, secure communication settings and cache TTL. This type of configuration is usually specified in `main()` in which `plugin.Start()` method is called.
2. **Run time configuration**
- **Global** - This config is useful if configuration data are needed to obtain list of metrics (for example: user names, paths to tools, etc.). Values from Global cofig (as defined in config json) are available in `GetMetricTypes()` method.
- **Task level** - This config is useful when you need to pass configuration per metric or plugin in order to collect the metrics. Use `GetConfigPolicy()` to set configurable items for plugin. Values from Task config are available in `CollectMetrics()` method.
Expand Down

0 comments on commit 981426b

Please sign in to comment.