Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

add conntrack counter and conntrack max #56

Closed
wants to merge 1 commit into from

Conversation

gregleroux
Copy link

Fixes #
#54

Summary of changes:
-add conntrack counter and conntrack max

How to verify it:

  • load task with this collected metrics:
    "/intel/psutil/net/conntrackcount": {},
    "/intel/psutil/net/conntrackmax": {}

Testing done:

A picture of a snapping turtle (not required but encouraged):

@snapbot
Copy link

snapbot commented Dec 21, 2016

Can one of the admins verify this patch?

@kindermoumoute kindermoumoute self-requested a review December 21, 2016 12:39
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few points:

  • You need to gofmt your code (net.go doesn't verify go format).
  • Medium test fail because it's using an old dependency of go-psutil, you need to update go-psutil dependency in glide.lock.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants