Add support for OpenShift management workload partitioning #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add annotations for OpenShift management workload partitioning. Administrators can opt into the feature by annotating the namespace with workload.openshift.io/allowed: management. Otherwise, these annotations will have no effect. Signed-off-by: Andreas Karis <ak.karis@gmail.com>
1ccb60f to
3084403
Compare
|
@MouliBurla can you check if this is something that would make sense? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add annotations for OpenShift management workload partitioning. The feature is opt-in. Administrators can opt into the feature by annotating the namespace with workload.openshift.io/allowed: management. Otherwise, these annotations will have no effect.
For further details, see:
In earlier versions of OpenShift (notably 4.14), management workload partitioning does not support pods with both limits and requests set: https://github.com/openshift/kubernetes/blob/fd36fb9acf9a99270f4fca3f5817fd52c8bc58b4/openshift-kube-apiserver/admission/autoscaling/managementcpusoverride/admission.go#L258
This only changed very recently (for not yet released OpenShift 4.16) with: openshift/kubernetes#1902
Therefore, when running on these older versions, the operator pod itself will still be skipped for management workload partitioning:
Implements: #62