[CMake][MSVC] Wrap more linker flags for IntelLLVM #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My previous pass missed some flags because I used `-Werror=unknown-argument`, but `/D` and `/G` are accepted by clang (even when only linking), but mean different things than intended for `link.exe`. Wrapping the linker with a script revealed these flags.
|
ping @wenju-he |
do you mean patch? |
I meant pass as in my previous sweep / attempt a over the code-base, but I can rephrase it if you prefer. |
I see, no need to change, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous pass missed some flags because I used
-Werror=unknown-argument, but/Dand/Gare accepted by clang (even when only linking), but mean different things than intended forlink.exe.Wrapping the linker with a script revealed these flags.
The approach I used to find these is documented as github gist here: https://gist.github.com/Maetveis/00567488f0d6ff74095d91ed306fafc5