Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVC VDEnc] Fix target usage mapping issue for free media driver #1055

Merged
merged 1 commit into from
Sep 22, 2020
Merged

[AVC VDEnc] Fix target usage mapping issue for free media driver #1055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 5 additions & 18 deletions media_driver/linux/common/codec/ddi/media_ddi_encode_avc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,32 +551,19 @@ VAStatus DdiEncodeAvc::ParseMiscParamQualityLevel(void *data)
VAEncMiscParameterBufferQualityLevel *vaEncMiscParamQualityLevel = (VAEncMiscParameterBufferQualityLevel *)data;

m_encodeCtx->targetUsage = (uint8_t)vaEncMiscParamQualityLevel->quality_level;
uint8_t qualityUpperBoundary = TARGETUSAGE_BEST_SPEED;
#ifdef _FULL_OPEN_SOURCE
if (!GFX_IS_PRODUCT(m_encodeCtx->pMediaCtx->platform, IGFX_ICELAKE_LP))
qualityUpperBoundary = 5;
#endif

// check if TU setting is valid, otherwise change to default
if ((m_encodeCtx->targetUsage > qualityUpperBoundary) || (0 == m_encodeCtx->targetUsage))
if ((m_encodeCtx->targetUsage > TARGETUSAGE_BEST_SPEED) || (0 == m_encodeCtx->targetUsage))
{
m_encodeCtx->targetUsage = TARGETUSAGE_RT_SPEED;
DDI_ASSERTMESSAGE("Quality Level setting from application is not correct, should be in (0,%d].", qualityUpperBoundary);
return VA_STATUS_SUCCESS;
DDI_ASSERTMESSAGE("Quality Level setting from application is not correct, should be in (0,%d].", TARGETUSAGE_BEST_SPEED);
}

#ifdef _FULL_OPEN_SOURCE
if (!GFX_IS_PRODUCT(m_encodeCtx->pMediaCtx->platform, IGFX_ICELAKE_LP))
if (!GFX_IS_PRODUCT(m_encodeCtx->pMediaCtx->platform, IGFX_ICELAKE_LP) && m_encodeCtx->targetUsage <= 3)
{
if (m_encodeCtx->targetUsage >= 1 && m_encodeCtx->targetUsage <= 2)
{
m_encodeCtx->targetUsage = 4;
}
else if (m_encodeCtx->targetUsage >= 3 &&m_encodeCtx->targetUsage <= 5)
{
m_encodeCtx->targetUsage = 7;
}
m_encodeCtx->targetUsage = 4;
}

#endif

return VA_STATUS_SUCCESS;
Expand Down