-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VAEncMiscParameterBufferQualityLevel need to reset for AVC/HEVC when sequence parameters reset. #7
Comments
you mean, even there are a new sequence parameters, driver should always keep previous quality level setting until next quality level setting, right? so , we should not set the default quality level in parsing sequence parameter function? |
Yes, I think quality level will keep unless user explicit change it, if user does not debug the driver, do you think any user know need to re-setting quality level when re-set sequence parameter? BTW: AVC/HEVC use a different default quality level value (1 for AVC, 4 for HEVC), I don't think this is a good idea from API view. |
sure , will submit a PR to fix it . thanks |
fix intel#7 Signed-off-by: XinfengZhang <carl.zhang@intel.com>
fix intel#7 Signed-off-by: XinfengZhang <carl.zhang@intel.com>
fix intel#7 Signed-off-by: XinfengZhang <carl.zhang@intel.com>
fix #7 Signed-off-by: XinfengZhang <carl.zhang@intel.com>
User need to reset VAEncMiscParameterBufferQualityLevel after reset sequence parameters , otherwise iHD driver won't use the expected quality level for encoding.
BTW: iHD driver uses a different quality level for AVC/HEVC when reset, AVC use 1, HEVC use 4.
I don't think this action follow the VA-API Spec, and iHD follow a counterintuitive way for Quality Level setting.
The text was updated successfully, but these errors were encountered: