Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAEncMiscParameterBufferQualityLevel need to reset for AVC/HEVC when sequence parameters reset. #7

Closed
mypopydev opened this issue Dec 4, 2017 · 3 comments · Fixed by #56
Assignees

Comments

@mypopydev
Copy link
Contributor

User need to reset VAEncMiscParameterBufferQualityLevel after reset sequence parameters , otherwise iHD driver won't use the expected quality level for encoding.

BTW: iHD driver uses a different quality level for AVC/HEVC when reset, AVC use 1, HEVC use 4.

I don't think this action follow the VA-API Spec, and iHD follow a counterintuitive way for Quality Level setting.

@XinfengZhang
Copy link
Contributor

you mean, even there are a new sequence parameters, driver should always keep previous quality level setting until next quality level setting, right? so , we should not set the default quality level in parsing sequence parameter function?

@mypopydev
Copy link
Contributor Author

Yes, I think quality level will keep unless user explicit change it, if user does not debug the driver, do you think any user know need to re-setting quality level when re-set sequence parameter?

BTW: AVC/HEVC use a different default quality level value (1 for AVC, 4 for HEVC), I don't think this is a good idea from API view.

@XinfengZhang
Copy link
Contributor

sure , will submit a PR to fix it . thanks

@XinfengZhang XinfengZhang self-assigned this Dec 26, 2017
XinfengZhang added a commit to XinfengZhang/media-driver that referenced this issue Dec 26, 2017
fix intel#7

Signed-off-by: XinfengZhang <carl.zhang@intel.com>
XinfengZhang added a commit to XinfengZhang/media-driver that referenced this issue Jan 10, 2018
fix intel#7

Signed-off-by: XinfengZhang <carl.zhang@intel.com>
XinfengZhang added a commit to XinfengZhang/media-driver that referenced this issue Jan 29, 2018
fix intel#7

Signed-off-by: XinfengZhang <carl.zhang@intel.com>
oliver-sang pushed a commit that referenced this issue Jan 31, 2018
fix #7

Signed-off-by: XinfengZhang <carl.zhang@intel.com>
oliver-sang pushed a commit that referenced this issue Jan 31, 2018
…#734426)

fix #7, PR #56
Signed-off-by: XinfengZhang <carl.zhang@intel.com>

Change-Id: I635d509c2b7066ffd71018b2ec3faf9908bff6a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants