Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Support partially linked fat objects in the bundler. #72

Merged
merged 2 commits into from
Apr 14, 2019
Merged

[SYCL] Support partially linked fat objects in the bundler. #72

merged 2 commits into from
Apr 14, 2019

Conversation

kbobrovs
Copy link
Contributor

Signed-off-by: Konstantin Bobrovsky konstantin.s.bobrovsky@intel.com

@kbobrovs kbobrovs force-pushed the sycl branch 3 times, most recently from bc1611b to bd7ef8d Compare April 10, 2019 19:35
@kbobrovs
[SYCL] Support partially linked fat objects in the bundler.
61b85f5 
Signed-off-by: Konstantin Bobrovsky <konstantin.s.bobrovsky@intel.com>
@bader
Copy link
Contributor

bader commented Apr 12, 2019 •
edited
Loading

@keryell, does this version addresses all your concerns?
See #68 for the history of this change.

keryell
keryell approved these changes Apr 13, 2019
View reviewed changes
Copy link
Contributor

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an interesting extension that looks good.

@bader bader merged commit e87838c into intel:sycl Apr 14, 2019
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Feb 23, 2023
@vladimirlaz
[SYCL] Remove use of deprecated environment variables (intel#72)
f903251 
Use of SYCL_BE and SYCL_DEVICE_TYPE was removed from LIT framework.
SYCL_DEVICE_FILTER is used instead:
 - update [CPU|GPU|ACC]_RUN_PLACEHOLDER to use SYCL_DEVICE_FILTER;
 - change values format used to define a backend and a device type to
match SYCL_DEVICE_FILTER requirements;
 - add BE_RUN_PLACEHOLDER to set backend only for tests which require
that;
 - add mapping from old SYCL backend name format to new one to avoid
   impact on CI automation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirlaz vladimirlaz vladimirlaz approved these changes

@keryell keryell keryell approved these changes

@bader bader bader approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kbobrovs @bader @keryell @vladimirlaz