[Driver][SYCL] refactor -fsycl-device-only behaviors #2713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update -fsycl-device-only to go through the offload path, effectively removing the host dependencies when it is used. This allows for a cleaner representation of SYCL device specific compilation needs.
0d10dbb to
5fcc96e
Compare
94f2e23 to
c570486
Compare
AGindinson
reviewed
Nov 2, 2020
AGindinson
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
LGTM!
As for the 1-line change in libclc, I get it @bader will be offline for the duration of the week. @romanovvlad, do you think this PR can be merged earlier as an exception?
jsji
pushed a commit
that referenced
this pull request
Sep 21, 2024
In LLVM, array allocations might have constant size: %array = alloca i32, i64 4, align 4 Represent this kind of allocations using OpVariable + OpBitcast. Before this patch, the SPV_INTEL_variable_length_array extension was used. Signed-off-by: Victor Perez <victor.perez@codeplay.com> Original commit: KhronosGroup/SPIRV-LLVM-Translator@ea2fcc172f6861e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update -fsycl-device-only to go through the offload path, effectively
removing the host dependencies when it is used. This allows for a
cleaner representation of SYCL device specific compilation needs.