-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Enable standard optimization pipeline for device code #2207
Conversation
/summary:run |
1 similar comment
/summary:run |
/summary:run |
I'd like to commit this patch ASAP to avoid regressions in the future. Let me now if you have any concerns about that plan. |
Add new compiler flag to disable optimizations at compile time: -fno-sycl-std-optimizations Temporally disable optimizations in some LIT tests.
54bdb93
to
0909cfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM except for one question - Should a comment be added to the 2 tests where optimizations were enabled before and now disabled, since this is a temporary change? |
I'll open an issue to update all the tests where optimizations were disabled due to different issues (there are more than 2 tests) and add a comment with issue ID to all the tests. |
d5ff978
Add new compiler flag to disable optimizations at compile time:
-fno-sycl-std-optimizations
Temporally disable optimizations in some LIT tests.