[SYCL] Remove re-flower pass #171
Conversation
6250ccd to
7da7103
Compare
| #endif | ||
|
|
||
| #define PPCAT_NX(A, B) A ## B | ||
| #define PPCAT(A, B) PPCAT_NX(A, B) |
There was a problem hiding this comment.
Perhaps adding an #undef at the end of the file for both of them too?
There was a problem hiding this comment.
I've added #undef-s. Thanks!
Signed-off-by: Mariya Podchishchaeva <mariya.podchishchaeva@intel.com>
event_t and sampler_t type names are replaced with __ocl_event_t and __ocl_sampler_t to avoid potential collisions with user types. This change allows to re-use OpenCL event and sampler types for SYCL and replace OpTypeEvent and OpTypeSampler with __ocl_event_t and __ocl_sampler_t in SYCL headers. OpenCL diagnostics is not enabled. Signed-off-by: Mariya Podchishchaeva <mariya.podchishchaeva@intel.com>
This change allows to avoid re-flower pass using. Signed-off-by: Mariya Podchishchaeva <mariya.podchishchaeva@intel.com>
Replace SPIR-V type names with built-in OpenCL type names. Use mangled class names in IR checking. Signed-off-by: Mariya Podchishchaeva <mariya.podchishchaeva@intel.com>
4ad8e9b to
7287fff
Compare
|
|
||
| // SPIRV type for sampler class | ||
| class OpTypeSampler; | ||
| // Only in such cases the class is recognized as SPIRV type __ocl_event_t. |
There was a problem hiding this comment.
Silly point to bring up, but should this read "Only in such cases the class is recognized as OpenCL type __ocl_event_t" rather than SPIRV?
There was a problem hiding this comment.
I think we want SPIR-V translator to recognize __ocl_event_t as OpTypeEvent. Right?
Looks like another place where auto-replace should have been skipped.
@Fznamznon, please, rallback this change, if you and @agozillon do not object.
There was a problem hiding this comment.
Ah, I understand. I have no objections.
There was a problem hiding this comment.
I think we should fully rewrite this comment (lines 39-42) because there is no more OCL C++ classes without definition. We use another approach now: we re-use OpenCL special opaque types in SYCL device compiler but we added aliases for these types to avoid potential conflicts with C++ code. We need the following typedefs only for host compiler because it doesn't know anything about these types.
Fixes #152