-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Graph] Update to UR cmd-buf enqueue rename #16747
Conversation
6ac4ddc
to
0b60a12
Compare
Reflects change in name of UR entry-point from `urCommandBufferEnqueueExp` to `urEnqueueCommandBufferExp` in oneapi-src/unified-runtime#2606
0b60a12
to
2954dac
Compare
ping @intel/llvm-reviewers-runtime for review |
@aelovikov-intel All the prebuilt e2e CI runs are failing here with tests that look too generic for my path. From reading #16793 & #16682 I don't understand what could be causing this, do you have any insight? |
Hard to say right now, let's get #16866 merged and rebase this on top of trunk after. |
0834ac4
to
b504a50
Compare
No worries 🙂 I've removed your commits now |
…e_refactor" This reverts commit cc60d08, from oneapi-src#2606 due to CI fails in the DPC++ bump PR that need further investigation intel/llvm#16747
Closing this PR and reverting the breaking UR changes in oneapi-src/unified-runtime#2688 Giving more time to investigate what's going with CI without blocking the UR merge queue |
I think there are two direct causes here leading to the test failures. The first one, as @aelovikov-intel pointed out, is the missing feature The second one is that some other failures( |
That is because |
I notice that those features are all tested in
(In https://github.com/intel/llvm/actions/runs/13265484428/job/37031762080, line 104607). I think there is a problem with those feature checks(maybe linking to an out-dated UR libs?), and I think it would impact any UR ABI breaking changes. Tagging @sarnex . I would stop my investigation here. Hope this is helpful. |
Thanks for taking the time to investigate, I've created an issue for this so that it can be better tracked and resolved #16982 |
**Same PR as was closed in intel#16747 due to intel#16982 Reflects change in name of UR entry-point from `urCommandBufferEnqueueExp` to `urEnqueueCommandBufferExp` in oneapi-src/unified-runtime#2606
I assigned the issue to myself and I'll take a look today, follow the issue for updates. |
**Same PR as was closed in intel#16747 due to intel#16982 Reflects change in name of UR entry-point from `urCommandBufferEnqueueExp` to `urEnqueueCommandBufferExp` in oneapi-src/unified-runtime#2606
This reverts commit cc60d08, from oneapi-src/unified-runtime#2606 due to CI fails in the DPC++ bump PR that need further investigation #16747
**Same PR as was closed in intel#16747 due to intel#16982 Reflects change in name of UR entry-point from `urCommandBufferEnqueueExp` to `urEnqueueCommandBufferExp` in oneapi-src/unified-runtime#2606
**Same PR as was closed in intel#16747 due to intel#16982 Reflects change in name of UR entry-point from `urCommandBufferEnqueueExp` to `urEnqueueCommandBufferExp` in oneapi-src/unified-runtime#2606
**Same PR as was closed in intel#16747 due to intel#16982 Reflects change in name of UR entry-point from `urCommandBufferEnqueueExp` to `urEnqueueCommandBufferExp` in oneapi-src/unified-runtime#2606
**Same PR as was closed in intel#16747 due to intel#16982 Reflects change in name of UR entry-point from `urCommandBufferEnqueueExp` to `urEnqueueCommandBufferExp` in oneapi-src/unified-runtime#2606
**Same PR as was closed in intel#16747 due to intel#16982 Reflects change in name of UR entry-point from `urCommandBufferEnqueueExp` to `urEnqueueCommandBufferExp` in oneapi-src/unified-runtime#2606
**Same PR as was closed in intel#16747 due to intel#16982 Reflects change in name of UR entry-point from `urCommandBufferEnqueueExp` to `urEnqueueCommandBufferExp` in oneapi-src/unified-runtime#2606
**Same PR as was closed in intel#16747 due to intel#16982 Reflects change in name of UR entry-point from `urCommandBufferEnqueueExp` to `urEnqueueCommandBufferExp` in oneapi-src/unified-runtime#2606
Reflects change in name of UR entry-point from
urCommandBufferEnqueueExp
tourEnqueueCommandBufferExp
in oneapi-src/unified-runtime#2606