Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Graph] Update to UR cmd-buf enqueue rename #16747

Closed
wants to merge 6 commits into from

Conversation

EwanC
Copy link
Contributor

@EwanC EwanC commented Jan 23, 2025

Reflects change in name of UR entry-point from
urCommandBufferEnqueueExp to urEnqueueCommandBufferExp in oneapi-src/unified-runtime#2606

Reflects change in name of UR entry-point from
`urCommandBufferEnqueueExp` to `urEnqueueCommandBufferExp`
in oneapi-src/unified-runtime#2606
@EwanC
Copy link
Contributor Author

EwanC commented Feb 3, 2025

ping @intel/llvm-reviewers-runtime for review

@EwanC
Copy link
Contributor Author

EwanC commented Feb 7, 2025

@aelovikov-intel All the prebuilt e2e CI runs are failing here with tests that look too generic for my path. From reading #16793 & #16682 I don't understand what could be causing this, do you have any insight?

@aelovikov-intel
Copy link
Contributor

@aelovikov-intel All the prebuilt e2e CI runs are failing here with tests that look too generic for my path. From reading #16793 & #16682 I don't understand what could be causing this, do you have any insight?

Hard to say right now, let's get #16866 merged and rebase this on top of trunk after.

@EwanC
Copy link
Contributor Author

EwanC commented Feb 11, 2025

Hi @EwanC , sorry for messing up your PR. I don't have permission to force-push and clear up my commit. Please help remove my accidentally added commit. Really sorry for that.

No worries 🙂 I've removed your commits now

EwanC added a commit to Bensuo/unified-runtime that referenced this pull request Feb 11, 2025
…e_refactor"

This reverts commit cc60d08, from
oneapi-src#2606 due to
CI fails in the DPC++ bump PR that need further investigation
intel/llvm#16747
@EwanC
Copy link
Contributor Author

EwanC commented Feb 11, 2025

Closing this PR and reverting the breaking UR changes in oneapi-src/unified-runtime#2688 Giving more time to investigate what's going with CI without blocking the UR merge queue

@EwanC EwanC closed this Feb 11, 2025
@yingcong-wu
Copy link
Contributor

yingcong-wu commented Feb 11, 2025

I think there are two direct causes here leading to the test failures.

The first one, as @aelovikov-intel pointed out, is the missing feature preview-breaking-changes-supported in the build stage, which lead to many conditional builds not being executed.

The second one is that some other failures( SYCL :: AtomicRef/device_has_aspect_atomic64_level_zero.cpp for example ), are listed as unsupported in the build stage, which also leads to missing executables in run stage. But the root cause is still under investigation.

@yingcong-wu
Copy link
Contributor

The second one is that some other failures( SYCL :: AtomicRef/device_has_aspect_atomic64_level_zero.cpp for example ), are listed as unsupported in the build stage, which also leads to missing executables in run stage. But the root cause is still under investigation.

That is because level_zero_dev_kit is also missing from build stage global features, together with cuda_dev_kit.

@yingcong-wu
Copy link
Contributor

yingcong-wu commented Feb 12, 2025

I notice that those features are all tested in llvm/sycl/test-e2e/lit.cfg.py using subprocess.getstatusoutput. I added a print to those tests and they all show the following error:

2025-02-11T15:09:01.2540004Z lit.py: /__w/llvm/llvm/llvm/sycl/test-e2e/lit.cfg.py:328: note: /usr/bin/ld: /__w/llvm/llvm/toolchain/bin/../lib/libsycl.so: undefined reference to `urEnqueueCommandBufferExp@LIBUR_LOADER_0.12'
2025-02-11T15:09:01.2540580Z clang++: error: linker command failed with exit code 1 (use -v to see invocation)
2025-02-11T15:09:01.2541173Z lit.py: /__w/llvm/llvm/llvm/sycl/test-e2e/lit.cfg.py:356: note: /usr/bin/ld: /__w/llvm/llvm/toolchain/bin/../lib/libsycl-preview.so: undefined reference to `urEnqueueCommandBufferExp@LIBUR_LOADER_0.12'

(In https://github.com/intel/llvm/actions/runs/13265484428/job/37031762080, line 104607).

I think there is a problem with those feature checks(maybe linking to an out-dated UR libs?), and I think it would impact any UR ABI breaking changes.

Tagging @sarnex .

I would stop my investigation here. Hope this is helpful.

@EwanC
Copy link
Contributor Author

EwanC commented Feb 12, 2025

Thanks for taking the time to investigate, I've created an issue for this so that it can be better tracked and resolved #16982

EwanC added a commit to reble/llvm that referenced this pull request Feb 12, 2025
**Same PR as was closed in intel#16747
due to intel#16982

Reflects change in name of UR entry-point from
`urCommandBufferEnqueueExp` to `urEnqueueCommandBufferExp` in oneapi-src/unified-runtime#2606
@sarnex
Copy link
Contributor

sarnex commented Feb 12, 2025

I assigned the issue to myself and I'll take a look today, follow the issue for updates.

EwanC added a commit to reble/llvm that referenced this pull request Feb 18, 2025
**Same PR as was closed in intel#16747
due to intel#16982

Reflects change in name of UR entry-point from
`urCommandBufferEnqueueExp` to `urEnqueueCommandBufferExp` in oneapi-src/unified-runtime#2606
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
This reverts commit cc60d08, from
oneapi-src/unified-runtime#2606 due to
CI fails in the DPC++ bump PR that need further investigation
#16747
EwanC added a commit to reble/llvm that referenced this pull request Feb 19, 2025
**Same PR as was closed in intel#16747
due to intel#16982

Reflects change in name of UR entry-point from
`urCommandBufferEnqueueExp` to `urEnqueueCommandBufferExp` in oneapi-src/unified-runtime#2606
EwanC added a commit to reble/llvm that referenced this pull request Feb 19, 2025
**Same PR as was closed in intel#16747
due to intel#16982

Reflects change in name of UR entry-point from
`urCommandBufferEnqueueExp` to `urEnqueueCommandBufferExp` in oneapi-src/unified-runtime#2606
EwanC added a commit to reble/llvm that referenced this pull request Feb 20, 2025
**Same PR as was closed in intel#16747
due to intel#16982

Reflects change in name of UR entry-point from
`urCommandBufferEnqueueExp` to `urEnqueueCommandBufferExp` in oneapi-src/unified-runtime#2606
EwanC added a commit to reble/llvm that referenced this pull request Feb 24, 2025
**Same PR as was closed in intel#16747
due to intel#16982

Reflects change in name of UR entry-point from
`urCommandBufferEnqueueExp` to `urEnqueueCommandBufferExp` in oneapi-src/unified-runtime#2606
EwanC added a commit to reble/llvm that referenced this pull request Feb 24, 2025
**Same PR as was closed in intel#16747
due to intel#16982

Reflects change in name of UR entry-point from
`urCommandBufferEnqueueExp` to `urEnqueueCommandBufferExp` in oneapi-src/unified-runtime#2606
EwanC added a commit to reble/llvm that referenced this pull request Feb 25, 2025
**Same PR as was closed in intel#16747
due to intel#16982

Reflects change in name of UR entry-point from
`urCommandBufferEnqueueExp` to `urEnqueueCommandBufferExp` in oneapi-src/unified-runtime#2606
EwanC added a commit to reble/llvm that referenced this pull request Feb 25, 2025
**Same PR as was closed in intel#16747
due to intel#16982

Reflects change in name of UR entry-point from
`urCommandBufferEnqueueExp` to `urEnqueueCommandBufferExp` in oneapi-src/unified-runtime#2606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants