[CI] Update sycl-windows-run-tests.yml #16621
Conversation
Added inputs.build_ref, which is used but not declared.
| @@ -18,6 +18,16 @@ on: | |||
| ref: | |||
| type: string | |||
| required: False | |||
| build_ref: | |||
There was a problem hiding this comment.
can we add a description explaining the difference between build_ref and ref? thx
There was a problem hiding this comment.
Is it better? 649afb6
There was a problem hiding this comment.
still unclear to me build_ref vs ref
There was a problem hiding this comment.
Me too:D it's not me who created this. Probably we can just use ref in both cases.
There was a problem hiding this comment.
Or, I don't know the original intent to have ref and build_ref, but may be it's to have a possibility to download the devops dir and the rest repo from different branches.
There was a problem hiding this comment.
as far as i know theres only a single ref that checks out the source branch for tests to run, if its not too much work maybe we try combining the two
There was a problem hiding this comment.
Removed build_ref. Also converted to draft so I can test it without random merge.
There was a problem hiding this comment.
cool, ping me again when youre ready for review/merge
There was a problem hiding this comment.
I'm afraid even we'd do some digging/archeology on git history, the result would it just happened without well-defined purpose behind it. Reviewing all *ref and removing/unifying unnecessary sounds like the right path forward.
There was a problem hiding this comment.
Ready for merge
cool, ping me again when youre ready for review/merge
Added merge_ref to inputs. Use ref instead of undeclared build_ref.