Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump UR and adjust use of urKernelSuggestMaxCooperativeGroupCountExp #15966

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Bump UR and adjust use of urKernelSuggestMaxCooperativeGroupCountExp #15966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
693e3d5
Bump UR and adjust use of urKernelSuggestMaxCooperativeGroupCountExp
igchor Nov 1, 2024
360e0e0
Merge remote-tracking branch 'origin/sycl' into cooperative_spec
martygrant Dec 19, 2024
0a78cf2
[UR] Update tag to ea0f3a1f for https://github.com/oneapi-src/unified…
martygrant Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sycl/cmake/modules/UnifiedRuntimeTag.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# commit bb64b3e9f6d30b232b204590b94250ce2da6967b
# Merge: d23739306f2c e625bfdaa99b
# commit ea0f3a1f5f15f9af7bf40bd13669afeb9ada569c
# Merge: bb64b3e9f6d3 4a89e1c69a65
# Author: Martin Grant <martin.morrisongrant@codeplay.com>
# Date: Martin Grant <martin.morrisongrant@codeplay.com>
# Merge pull request #2471 from Bensuo/ben/l0-include-fix
# [L0] Fix issue with test include path
set(UNIFIED_RUNTIME_TAG bb64b3e9f6d30b232b204590b94250ce2da6967b)
# Date: Thu Dec 19 11:26:01 2024 +0000
# Merge pull request #2277 from igchor/cooperative_fix
# [Spec] fix urKernelSuggestMaxCooperativeGroupCountExp
set(UNIFIED_RUNTIME_TAG ea0f3a1f5f15f9af7bf40bd13669afeb9ada569c)
4 changes: 3 additions & 1 deletion sycl/source/detail/kernel_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,7 @@ kernel_impl::queryMaxNumWorkGroups(queue Queue,
const auto &Adapter = getAdapter();
const auto &Handle = getHandleRef();
auto Device = Queue.get_device();
auto DeviceHandleRef = sycl::detail::getSyclObjImpl(Device)->getHandleRef();

size_t WG[Dimensions];
WG[0] = WorkGroupSize[0];
Expand All @@ -331,7 +332,8 @@ kernel_impl::queryMaxNumWorkGroups(queue Queue,
uint32_t GroupCount{0};
if (auto Result = Adapter->call_nocheck<
UrApiKind::urKernelSuggestMaxCooperativeGroupCountExp>(
Handle, Dimensions, WG, DynamicLocalMemorySize, &GroupCount);
Handle, DeviceHandleRef, Dimensions, WG, DynamicLocalMemorySize,
&GroupCount);
Result != UR_RESULT_ERROR_UNSUPPORTED_FEATURE &&
Result != UR_RESULT_ERROR_INVALID_WORK_GROUP_SIZE) {
// The feature is supported and the group size is valid. Check for other
Expand Down
Loading