LLM: fix error of 'AI-ModelScope/phi-2' hosted by ModelScope hub #10364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnwang04
approved these changes
Mar 11, 2024
Sure, have added some comments to illustrate. Will merge it after style ut pass. |
liu-shaojun
pushed a commit
that referenced
this pull request
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In ModelScope,
model_typeofAI-ModelScope/phi-2isphi-msft.Then optimization for
phixtralis applied tophi-2and will cause error. More details are in https://github.com/analytics-zoo/nano/issues/1140#issuecomment-19875340962. User API changes
N/A
4. How to test?