-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update gpu-resource-driver chart to v0.6.0 #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK, but I think CRDs still need to be mentioned due to upgrading.
d09c60d
to
b23e1e3
Compare
charts/intel-gpu-resource-driver/templates/validating-admission-policy-binding.yaml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, but please update README note to match better what user needs to do when upgrading to this specific version.
40a87ca
to
573d0e8
Compare
Signed-off-by: Oksana Baranova <oksana.baranova@intel.com>
charts/intel-gpu-resource-driver/templates/validating-admission-policy-binding.yaml
Show resolved
Hide resolved
charts/intel-gpu-resource-driver/templates/resource-driver.yaml
Outdated
Show resolved
Hide resolved
# Use this to tell kubelet-plugin where the DRI devices nodes should be. | ||
# Only use devdri when using fake devfs with device-faker. | ||
# Use this to tell kubelet-plugin where the fake DRI devices nodes are. | ||
# This will be prefix for CDI devices, runtime will try to mount devices | ||
# with this prefix into workloads. | ||
# with this prefix into workloads, so the path should be equal to where | ||
# fake DRI files are in real host. | ||
#- name: DEV_DRI_PATH | ||
# value: "/fake/dri" | ||
# value: "/tmp/test-0123456789/dev/dri" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed, will only confuse people, let's have it in source code repo deployment files only for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will redo that.
I used our public repo when creating the chart https://github.com/intel/intel-resource-drivers-for-kubernetes/blob/main/deployments/gpu/resource-driver.yaml to update needed files. That is a bit confusing because these changes are in our public repository and available for end users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the confusion, but you need to understand the purpose. When deploying the yamls manually - you can change that to point to where you've created the fake sysfs and devfs. With helm - we do not expect anyone to change the template, right? Instead you would use templating approach and hide these behind a flag in values.yaml and the proper value that can be set when installing the chart...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will look better later in Q4 when it will be possible to use the fake sysfs generator as an init container...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some excessive deletion detected :)
No description provided.