fix bug of evaluate user model #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: n1ck-guo <heng.guo@intel.com>
wenhuach21
reviewed
Feb 17, 2025
wenhuach21
reviewed
Feb 17, 2025
auto_round/utils.py
Outdated
| device_str = None | ||
| device_str = None | ||
| else: | ||
| device_str = detect_device(devices[0]) |
There was a problem hiding this comment.
it is quite confusing if device is set to 0,1 and detect_device return 0?
There was a problem hiding this comment.
if multi card or auto set, will return None. If only one card set, will return like cuda:1.
There was a problem hiding this comment.
then why using devices[0] not devices
There was a problem hiding this comment.
if the device is set to "cpu" or "hpu", is devices[0] still correct?
wenhuach21
reviewed
Feb 17, 2025
auto_round/utils.py
Outdated
| device_str = None | ||
| device_str = None | ||
| else: | ||
| device_str = detect_device(devices[0]) | ||
| elif device == "auto": | ||
| device_str = None |
There was a problem hiding this comment.
why set_cuda_visible_devices also set parallelism, it's not a good coding style. Set cuda visible device first, then set parallelism.
Similar coding style issue in detect_devices
wenhuach21
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.