Add clangd config check in checkCompileCommandsConfig() #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if vscode-clangd installed but `--compile-commands-dir=`
is not setting or setting is not "${workspaceFolder}/.edkCode/",
then update clangd.arguments to include:
"--compile-commands-dir=${workspaceFolder}/.edkCode/".
if vscode-clangd is not installed, still call infoMissingCompilesCommandCpp()
Signed-off-by: Yang Gang <yanggang@byosoft.com.cn>
|
Thanks @YangGangUEFI , I will include this change in the following release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if
vscode-clangdinstalled but--compile-commands-dir=is not setting or setting is not "${workspaceFolder}/.edkCode/", then updateclangd.argumentsto include:"--compile-commands-dir=${workspaceFolder}/.edkCode/".if
vscode-clangdis not installed, still callinfoMissingCompilesCommandCpp()BTW: As the message in
infoMissingCompilesCommandCpp()has been updated, so this wiki page may need update to include some material aboutvscode-clangd.