Expose serialization size parameters directly. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are fixed in the specification and cannot change. Better for dependent projects to get these numbers from this crate than to encode them by hand.
|
I've been trying to write some simple code that uses this module, and found it was useful to be able to get at these sizes without having to instantiate objects and inspect them. Adding these consts to the public API of the crate doesn't seem to risk any future API churn, as these values are static in the specification draft itself. |
|
You are absolutely right - thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are fixed in the specification and cannot change. Better for dependent projects to get these numbers from this crate than to encode them by hand.