Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for GitHub Enterprise Cloud Data residency #2547

Merged
merged 4 commits into from
Feb 27, 2025
Merged

Add support for GitHub Enterprise Cloud Data residency #2547

merged 4 commits into from
Feb 27, 2025

Conversation

EricDales
Copy link
Contributor

Resolves #2546

Before the change?

  • setting BaseURL to a value other than api.github.com implies the instance is considered as GHES instance

After the change?

  • provider is able to identify GHEC data residency URL and use the correct API paths

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

kfcampbell
kfcampbell approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build was failing, so I fixed that and added a couple of test cases for the regex. I think this is good to go now.

@kfcampbell kfcampbell merged commit c99f24e into integrations:main Feb 27, 2025
3 checks passed
@EricDales
Copy link
Contributor Author

Thanks a ton Keegan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfcampbell kfcampbell kfcampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT]: Add support for GitHub Enterprise Cloud Data Residency
2 participants
@EricDales @kfcampbell