-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for merge queues in repository rulesets #2380
Conversation
Waiting for SDK to be released before rebasing and putting for review. Wanted to get some early feedback on:
|
cb8ab58
to
b5a3a69
Compare
@kfcampbell This is ready for review now :) |
Love to see this go in 🙏 |
This would be very useful for us. |
02b1017
to
da0f157
Compare
it would be awesome if this could be merged soon. |
@kfcampbell @nickfloyd gentle bump, can we get some eyes on this PR please |
aaa5906
to
139d09d
Compare
Bumping this again, been very long now we are stuck on this old forked privier, anything more needed to get this reviewed and merged? @kfcampbell |
This would be very useful for us as well |
+1 |
+1, please expedite this 🙏 |
+1 |
@kfcampbell we are blocked on this as well. Could this get merged? |
@kfcampbell @nickfloyd We would also love this feature to be merged - it's preventing us from going all-in on this provider, leaving us with maintaining 1000+ of lines of custom Powershell code... :/ |
@kfcampbell @nickfloyd - any update on this getting merged? Appreciate it!! |
@kfcampbell @nickfloyd is there something missing or needed to be done to get this PR going? There have been multiple releases since this has been ready for review several months ago now. Would really like to get us off of what was hoped to be a short lived private build of this provider until this was merged. From the comments here it would be of great value to many others too. If there is anything else needed, please let me know so that I can get it done. |
+1 with all the echos above trying to get this merged, I'm also trying to get our corporate GitHub account manager to help escalate with this review, but got no responses so far. If you have a GitHub account manager at your corporation would be great if you can also shoot them an email. |
Bumping this with the hope it can be merged almost 6 months since beigng ready.. @kfcampbell @nickfloyd |
I hope this can be soon reviewed and merged I'm looking forward of using the merge queue feature. |
Apologies for the delay here, @nickfloyd have been working on other workstreams internal to GitHub. We're experimenting with a workflow that gives us a day per month for SDK reviews and releases now. The existing integration tests were broken here, so I've pushed 7b10791 and 5c70857 with some test and util fixes. Integration tests are now good, and I'll do some manual testing before merge/release soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've manually validated this now in a few different scenarios. I'll merge and release shortly.
Resolves #1481
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!