-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Refactored tooling for best practices #2193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the attention paid to the details here. I had a first pass of questions/comments.
fc77d00
to
6051d1b
Compare
@kfcampbell I've replied to your questions. |
6051d1b
to
ec70d06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had one final question, thank you for your patience here.
update-types: | ||
- minor | ||
- patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not include major version updates here and below? Shouldn't the PR fire so we're aware the update exists even if we don't want to take it immediately?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this config major version updates will be managed in individual PRs while minor and patch updates will be grouped in a single PR per ecosystem.
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
244d0a0
to
204721a
Compare
@kfcampbell I've rebased this ready to be merged. |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github](https://registry.terraform.io/providers/integrations/github) ([source](https://togithub.com/integrations/terraform-provider-github)) | required_provider | patch | `6.2.1` -> `6.2.2` | --- ### Release Notes <details> <summary>integrations/terraform-provider-github (github)</summary> ### [`v6.2.2`](https://togithub.com/integrations/terraform-provider-github/releases/tag/v6.2.2) [Compare Source](https://togithub.com/integrations/terraform-provider-github/compare/v6.2.1...v6.2.2) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### 🛠️ Maintenance - build(deps): bump actions/add-to-project from 0.6.1 to 1.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2215](https://togithub.com/integrations/terraform-provider-github/pull/2215) - build(deps): bump github.com/golangci/golangci-lint from 1.57.1 to 1.57.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2216](https://togithub.com/integrations/terraform-provider-github/pull/2216) - build(deps): bump the github-actions group with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2218](https://togithub.com/integrations/terraform-provider-github/pull/2218) - build(deps): bump github/codeql-action from 3.24.9 to 3.24.10 in the github-actions group by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2221](https://togithub.com/integrations/terraform-provider-github/pull/2221) - build(deps): bump the gomod group with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2220](https://togithub.com/integrations/terraform-provider-github/pull/2220) - build(deps): bump actions/add-to-project from 1.0.0 to 1.0.1 in the github-actions group by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2231](https://togithub.com/integrations/terraform-provider-github/pull/2231) - build(deps): bump golang.org/x/net from 0.22.0 to 0.23.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2234](https://togithub.com/integrations/terraform-provider-github/pull/2234) - build(deps): bump the github-actions group with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2238](https://togithub.com/integrations/terraform-provider-github/pull/2238) - build(deps): bump the github-actions group with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2244](https://togithub.com/integrations/terraform-provider-github/pull/2244) - build(deps): bump the gomod group with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2257](https://togithub.com/integrations/terraform-provider-github/pull/2257) - build(deps): bump actions/setup-go from 5.0.0 to 5.0.1 in the github-actions group by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2256](https://togithub.com/integrations/terraform-provider-github/pull/2256) - build(deps): bump the github-actions group with 3 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2259](https://togithub.com/integrations/terraform-provider-github/pull/2259) - build(deps): bump the gomod group with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2260](https://togithub.com/integrations/terraform-provider-github/pull/2260) - build(deps): bump the github-actions group with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2268](https://togithub.com/integrations/terraform-provider-github/pull/2268) - build(deps): bump github/codeql-action from 3.25.5 to 3.25.6 in the github-actions group by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2272](https://togithub.com/integrations/terraform-provider-github/pull/2272) - build(deps): bump the gomod group across 1 directory with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2271](https://togithub.com/integrations/terraform-provider-github/pull/2271) - 🚧 Workflows have changed by [@​octokitbot](https://togithub.com/octokitbot) in [https://github.com/integrations/terraform-provider-github/pull/2281](https://togithub.com/integrations/terraform-provider-github/pull/2281) - build(deps): bump the gomod group with 3 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2287](https://togithub.com/integrations/terraform-provider-github/pull/2287) - build(deps): bump github/codeql-action from 3.25.6 to 3.25.8 in the github-actions group across 1 directory by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2286](https://togithub.com/integrations/terraform-provider-github/pull/2286) - build(deps): bump the github-actions group with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2292](https://togithub.com/integrations/terraform-provider-github/pull/2292) - build(deps): bump goreleaser/goreleaser-action from 5.1.0 to 6.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2293](https://togithub.com/integrations/terraform-provider-github/pull/2293) ##### 🏷 Other Changes - chore: Refactored tooling for best practices by [@​stevehipwell](https://togithub.com/stevehipwell) in [https://github.com/integrations/terraform-provider-github/pull/2193](https://togithub.com/integrations/terraform-provider-github/pull/2193) - changed logic on repositories_detailed by [@​n47h4n12](https://togithub.com/n47h4n12) in [https://github.com/integrations/terraform-provider-github/pull/2248](https://togithub.com/integrations/terraform-provider-github/pull/2248) - improve documentation for `github_repository` by [@​garysassano](https://togithub.com/garysassano) in [https://github.com/integrations/terraform-provider-github/pull/2265](https://togithub.com/integrations/terraform-provider-github/pull/2265) - docs: update title and code highlighting for github_repository_ruleset by [@​stefanfreitag](https://togithub.com/stefanfreitag) in [https://github.com/integrations/terraform-provider-github/pull/2285](https://togithub.com/integrations/terraform-provider-github/pull/2285) - docs: add missing quote in branch protection v3 example by [@​stefanfreitag](https://togithub.com/stefanfreitag) in [https://github.com/integrations/terraform-provider-github/pull/2283](https://togithub.com/integrations/terraform-provider-github/pull/2283) - Goreleaser deprecation: skip --> disable by [@​kfcampbell](https://togithub.com/kfcampbell) in [https://github.com/integrations/terraform-provider-github/pull/2294](https://togithub.com/integrations/terraform-provider-github/pull/2294) #### New Contributors - [@​stevehipwell](https://togithub.com/stevehipwell) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/2193](https://togithub.com/integrations/terraform-provider-github/pull/2193) - [@​n47h4n12](https://togithub.com/n47h4n12) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/2248](https://togithub.com/integrations/terraform-provider-github/pull/2248) - [@​garysassano](https://togithub.com/garysassano) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/2265](https://togithub.com/integrations/terraform-provider-github/pull/2265) - [@​stefanfreitag](https://togithub.com/stefanfreitag) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/2285](https://togithub.com/integrations/terraform-provider-github/pull/2285) **Full Changelog**: integrations/terraform-provider-github@v6.2.1...v6.2.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS90ZXJyYWZvcm0iLCJ0eXBlL3BhdGNoIl19--> Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
This PR refactors the provider tooling to align it to GitHub Actions best practices and TF provider best practices. The following things have changed, but there shouldn't be a material change in how the project works.
golangci-lint
config to the recommended patterngoreleaser
config