docs: Clarify how allows_force_pushes works #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meliamzz
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2054
#2054 is not really a bug, it's more a documentation issue.
At graphql level,
allowsForcePusheswill betrueonly if everyone is allowed to bypass. If a list of bypasser is provided,allowsForcePusheswill befalse.So in the terraform config, when
force_push_bypassersis used,allowsForcePushesshould be kept to `false.This PR improves the doc and add a unit test.
I can add a validation on the config to block wrong configs when the two variables are not coherent, but it can broke some existing config.