Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add delete branch on merge option on datasource github repository #2046

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

alileza
Copy link
Contributor

@alileza alileza commented Dec 6, 2023

After the change?

Supporting a couple more fields from repository api

  • delete_on_branch_merge
  • get_allow_update_branch

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@alileza alileza marked this pull request as ready for review December 9, 2023 15:36
@alileza alileza marked this pull request as draft December 9, 2023 22:34
@nickfloyd nickfloyd added the Type: Feature New feature or request label Jan 4, 2024
@kfcampbell
Copy link
Member

@alileza feel free to promote this from draft when you're comfortable!

@alileza alileza marked this pull request as ready for review January 10, 2024 12:50
@kfcampbell
Copy link
Member

Would you mind adding checks for these new attributes to github/data_source_github_repository_test.go?

Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for the changes here! ❤️ We'll go ahead and merge / ship this but if you get the chance would you mind adding your fields to the documentation as well?

@nickfloyd nickfloyd merged commit 182f8e0 into integrations:main Aug 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants