Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Actually populate the visibility within the resulting object. #1486

Merged

Conversation

wwsean08
Copy link
Contributor

Found while working on #1414, however it doesn't resolve the issue. I did a quick search and it doesn't look like anybody has reported this issue yet.


Behavior

Before the change?

  • Currently github_actions_organization_secrets does not fill in the visibility field, leaving it blank on all requests

After the change?

  • The github_actions_organization_secrets field is filled in with the proper value

Other information

  • I change the test to create a secret with the all visibility, as private requires a paid subscription which many folks may not have, allowing for more people to work on this and be able to run the tests.

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug

Testing

Tests were performed by running the acceptance test where I found this issue

Before Change

Screenshot 2023-01-14 at 1 44 55 PM

After Change

Screenshot 2023-01-14 at 1 44 14 PM

Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that integration tests are failing on main for me and passing on this branch.

Thank you for the contribution; this is awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants