Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Operate hashed Member credentials (#165, #27) #168

Merged
merged 20 commits into from
Jan 4, 2021

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Dec 25, 2020

Part of #27
Fixes #165

Synopsis

We need to implement ability to check Member' s credentials by Argon2 hash provided by Control API.

Solution

Algorithm described in the #165.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs changed the title Draft: Operate hashed Member credentials (#165, #27 Draft: Operate hashed Member credentials (#165, #27) Dec 25, 2020
@evdokimovs evdokimovs self-assigned this Dec 25, 2020
@evdokimovs evdokimovs added enhancement Improvement of existing features or bugfix feature New feature or request k::api Related to API (application interface) k::config Related to application configuration k::design Related to overall design and/or architecture labels Dec 25, 2020
@evdokimovs evdokimovs added this to the 0.2.0 milestone Dec 25, 2020
@evdokimovs evdokimovs marked this pull request as draft December 25, 2020 10:11
@evdokimovs
Copy link
Contributor Author

evdokimovs commented Dec 25, 2020

FCM

Operate hashed Member credentials (#168, #165, #27)

- add ability to specify credentials hash in Control API
- implement Web Client credentials verification via Argon2 hash received from Control API
- change Join URI format to: {{ Host }}/{{ Room ID }}/{{ Member ID }}?token={{ Token }}

@evdokimovs evdokimovs marked this pull request as ready for review December 25, 2020 14:27
@evdokimovs evdokimovs requested a review from alexlapa December 25, 2020 14:28
@alexlapa alexlapa requested a review from tyranron January 4, 2021 08:44
@tyranron tyranron changed the title Draft: Operate hashed Member credentials (#165, #27) Operate hashed Member credentials (#165, #27) Jan 4, 2021
@tyranron tyranron added k::security Related to security and removed k::config Related to application configuration labels Jan 4, 2021
@evdokimovs evdokimovs merged commit 81e437c into master Jan 4, 2021
@evdokimovs evdokimovs deleted the 165-hashed-credentials branch January 4, 2021 16:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement of existing features or bugfix feature New feature or request k::api Related to API (application interface) k::design Related to overall design and/or architecture k::security Related to security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operate hashed Member credentials instead of plain ones
3 participants