Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Implement ICE restart (#27) #138

Merged
merged 31 commits into from
Sep 22, 2020
Merged

Implement ICE restart (#27) #138

merged 31 commits into from
Sep 22, 2020

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Sep 9, 2020 •
edited
Loading

Part of #27

Synopsis

When RTCPeerConnection.connectionState goes into Failed state, we need to restart ICE.

Solution

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added feature New feature or request k::api Related to API (application interface) labels Sep 9, 2020
@evdokimovs evdokimovs self-assigned this Sep 9, 2020
@evdokimovs evdokimovs added this to the 0.2.0 milestone Sep 9, 2020
@evdokimovs
Copy link
Contributor Author

evdokimovs commented Sep 9, 2020 •
edited by tyranron
Loading

FCM

Implement ICE restart (#138, #27)

- add IceRestart variant to the TrackUpdate in Client API
- send TrackUpdate::IceRestart based on client's RTC stats
- handle TrackUpdate::IceRestart in Jason

@evdokimovs evdokimovs marked this pull request as ready for review September 9, 2020 13:34
@evdokimovs evdokimovs changed the title Draft: Implement ICE restart (#27) Implement ICE restart (#27) Sep 9, 2020
@evdokimovs evdokimovs requested a review from alexlapa September 9, 2020 13:35
@evdokimovs evdokimovs mentioned this pull request Sep 14, 2020
Merged
16 tasks
@alexlapa alexlapa requested a review from tyranron September 21, 2020 11:18
@tyranron tyranron added the k::design Related to overall design and/or architecture label Sep 22, 2020
@evdokimovs evdokimovs merged commit 91cf554 into master Sep 22, 2020
@evdokimovs evdokimovs deleted the restart-ice branch September 22, 2020 09:02
@tyranron tyranron mentioned this pull request Sep 22, 2020
Closed
16 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexlapa alexlapa alexlapa approved these changes

@tyranron tyranron tyranron approved these changes

Assignees

@evdokimovs evdokimovs

Labels
feature New feature or request k::api Related to API (application interface) k::design Related to overall design and/or architecture
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@evdokimovs @tyranron @alexlapa