Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Implement MediaTracks removing (#27) #109

Merged
merged 152 commits into from
Mar 31, 2021
Merged

Implement MediaTracks removing (#27) #109

merged 152 commits into from
Mar 31, 2021

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Jun 16, 2020 •
edited by tyranron
Loading

Part of #27

Requires #105

Synopsis

Currently, if Control API client asks Media Server to remove Endpoint which is already interconnected with some another Endpoint - Peer connection between two Members will be removed instead of removing concrete MediaTracks related to the removed Endpoint from those Peer connections.

Solution

  • 1. Implement TracksRemoved event on client and server
  • 2. Remove MediaTrack related to removed Endpoint on Endpoint remove

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

evdokimovs and others added 30 commits May 21, 2020 14:21
@evdokimovs
Add server-side renegotiation logic
e9a62ad
@evdokimovs
Add client side logic for renegotiation
9d63073
@evdokimovs
Add code for testing renegotiation
5398103
@evdokimovs
Clean unused code
311e592
@evdokimovs
WIP
2e4d144
@evdokimovs
Add debuging code
8e16b7c
@evdokimovs
Fix renegotiation in the Firefox
447f4bd
@evdokimovs
Merge branch 'master' into renegotiation
b06a97a
@evdokimovs
Add docs, refactor
3fc35e1
@alexlapa
Merge branch 'master' into renegotiation
42e7f5b
@alexlapa
refactor
510f038
@evdokimovs
WIP
0f73f7a
@evdokimovs
Temporary revert broken commits
c3c1736
@evdokimovs
Remove PeerConnectionState and related things
6420477
@evdokimovs
Add new renegotiation
9568c76
@evdokimovs
Implement tracks adding
de4ff6b
@evdokimovs
New impl for connect_endpoints
019fafd
@evdokimovs
Refactor
3074d28
@evdokimovs
Refactor
9df37c2
@evdokimovs
Take into account RenegotiationReason
52fd4c5
@evdokimovs
Pick room changes, fix Member interconnecting on Endpoint creating
29c6902
@evdokimovs
Cleanup
d6c17d9
@evdokimovs
connect_endpoints error handling
338abe5
@evdokimovs
Remove all unsafe code from actix_try_join_all
d0da210
@evdokimovs
Normal PeerSpec updating
340fba6
@evdokimovs
Refactor
f0bea8e
@evdokimovs
Fix tests
b85372b
@evdokimovs
Add Event::TracksAdded to the RFC
163847e
@evdokimovs
Add docs
afb7cb3
@evdokimovs
Upd CHANGELOGs
3f8d8d6
@alexlapa alexlapa self-requested a review March 25, 2021 11:05
@alexlapa alexlapa marked this pull request as ready for review March 25, 2021 11:05
@alexlapa alexlapa requested a review from tyranron March 26, 2021 15:58
tyranron
tyranron suggested changes Mar 30, 2021
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be so kind to actualize this with recent master?

@evdokimovs evdokimovs requested a review from tyranron March 30, 2021 17:44
@tyranron tyranron changed the title Draft: Implement MediaTracks removing (#27) Implement MediaTracks removing (#27) Mar 31, 2021
@tyranron
Copy link
Member

@evdokimovs wait pipeline to proceed well before merge.

@evdokimovs evdokimovs merged commit 2f78455 into master Mar 31, 2021
@evdokimovs evdokimovs deleted the delete-tracks branch March 31, 2021 11:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexlapa alexlapa alexlapa approved these changes

@tyranron tyranron tyranron approved these changes

Assignees

@evdokimovs evdokimovs

Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface)
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@evdokimovs @tyranron @alexlapa