Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Upload phase 1 & phase 2 training logs for loss graphs #356

Merged
merged 1 commit into from
Nov 29, 2024
Merged

ci: Upload phase 1 & phase 2 training logs for loss graphs #356

merged 1 commit into from
Nov 29, 2024

Conversation

alimaredia
Copy link
Contributor

@alimaredia alimaredia commented Nov 25, 2024 •
edited by danmcp
Loading

Resolves: #359

@mergify mergify bot added CI/CD Affects CI/CD configuration ci-failure labels Nov 25, 2024
@alimaredia alimaredia force-pushed the fix-loss-graphs-ci branch 3 times, most recently from 8352fba to f261630 Compare November 25, 2024 18:30
@mergify mergify bot removed the ci-failure label Nov 25, 2024
RobotSail
RobotSail reviewed Nov 26, 2024
View reviewed changes
Copy link
Member

@RobotSail RobotSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the quick PR Ali! I've provided some inline suggestions to fix a few issues in the PR. Once those are made we can go ahead and merge this. Appreciate you taking this on!!

@github-actions GitHub Actions
Copy link

E2E (NVIDIA L40S x4) workflow launched on this PR: View run

RobotSail
RobotSail approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@RobotSail RobotSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your work on this! LGTM

@mergify mergify bot added the one-approval label Nov 27, 2024
@github-actions GitHub Actions
Copy link

E2E (NVIDIA L40S x4) workflow launched on this PR: View run

@github-actions GitHub Actions
Copy link

e2e workflow succeeded on this PR: View run, congrats!

@mergify mergify bot added the ci-failure label Nov 27, 2024
@mergify mergify bot removed the ci-failure label Nov 28, 2024
@danmcp danmcp force-pushed the fix-loss-graphs-ci branch from b912199 to 0e7f167 Compare November 29, 2024 16:47
@mergify mergify bot added the ci-failure label Nov 29, 2024
@alimaredia @danmcp
ci: Upload phase 1 & phase 2 training logs for loss graphs
69fdaee 
Signed-off-by: Ali Maredia <amaredia@redhat.com>

Co-authored-by: Dan McPherson <dmcphers@redhat.com>
@danmcp danmcp force-pushed the fix-loss-graphs-ci branch from 0e7f167 to 69fdaee Compare November 29, 2024 16:50
@mergify mergify bot removed the one-approval label Nov 29, 2024
RobotSail
RobotSail approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@RobotSail RobotSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 9e3b74a into instructlab:main Nov 29, 2024
14 checks passed
@mergify mergify bot removed the ci-failure label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobotSail RobotSail RobotSail approved these changes

@danmcp danmcp danmcp approved these changes

Assignees
No one assigned
Labels
CI/CD Affects CI/CD configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create separate CI step for uploading & exporting the loss curves
3 participants
@alimaredia @danmcp @RobotSail