This repository has been archived by the owner on Jan 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
feat: store icons next to the component definition #58
Merged
donch1989
merged 2 commits into
main
from
jvalles/ins-3621-move-component-icons-from-console-to-their-component-package
Feb 15, 2024
Merged
feat: store icons next to the component definition #58
donch1989
merged 2 commits into
main
from
jvalles/ins-3621-move-component-icons-from-console-to-their-component-package
Feb 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donch1989
previously approved these changes
Feb 7, 2024
bbf3432
to
2f7d097
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
=======================================
Coverage 67.93% 67.93%
=======================================
Files 6 6
Lines 658 658
=======================================
Hits 447 447
Misses 168 168
Partials 43 43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
donch1989
previously approved these changes
Feb 8, 2024
2f7d097
to
e047a7c
Compare
Base automatically changed from
jvalles/ins-3620-add-version-to-existing-components
to
main
February 9, 2024 08:47
Updates the feature to the v0.1.0-alpha migration
e047a7c
to
0e29964
Compare
@jvallesm console will support this in this sprint, please merge the PR when you are ready |
EiffelFly
added a commit
to instill-ai/console
that referenced
this pull request
Feb 15, 2024
Because - backend have breaking changes related to icon path due to we try to centralize the management of connector's icons - instill-ai/connector#122 - instill-ai/operator#58 This commit - support the backend breaking changes of icon path
donch1989
pushed a commit
that referenced
this pull request
Feb 16, 2024
🤖 I have created a release *beep* *boop* --- ## [0.8.0-beta](v0.7.0-beta...v0.8.0-beta) (2024-02-16) ### Features * implement jq task in JSON operator ([#61](#61)) ([f38cd90](f38cd90)) * **json:** use `semi-structured/json` in TASK_MARSHAL and TASK_UNMARSHAL ([#62](#62)) ([acbe2db](acbe2db)) * set component versions to 0.1.0-alpha ([#59](#59)) ([80df32e](80df32e)) * store icons next to the component definition ([#58](#58)) ([9fea343](9fea343)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
ListoperatorDefinitions
endpoint.This commit
Notes
🫥
start
andend
had an icon path that doesn't exist inconsole
. The icons were imported as well, it was decided that all components should have the same icon treatment.🪶 The icons aren't used in the backend code so we could exclude them from the image build to have lighter images.
👯 Copy was automated with the following script: