fix(test): inject dummy OAuth values in integration tests #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvallesm
added a commit
to instill-ai/pipeline-backend
that referenced
this pull request
Feb 4, 2025
Because - Some EasyOCR models are needed by Docling to transform PDF to Markdown. Without them, the first execution of the document component fails because the output starts by a "Downloading detection model, please wait..." print. - This also prevented coverage for the Docling converter. - The `use-docling` parameter in the document operator is less open to changes that an enum `converter` selector. This commit - Adds the EasyOCR models to the Docker images. - Corrects the integration test in the CI after [the latest changes in instill-core ](instill-ai/instill-core#1172). - Replaces the `use-docling` parameter by `converter`. The following changes are made on the `Dockerfile`: - `nobody:nogroup` needs to have a $HOME where the EasyOCR models will be placed (internally, this engine looks for the models in `~/.EasyOCR/model`). - The workdir (`/pipeline-backend`) is owned by `nobody:nogroup` in the dev image so we can run the coverage action without the root user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
the OAuth configuration. This was required to enable OAuth for the GitHub
component, whose OAuth integration was later tested. On local testing,
however, we relied on these values to be present on .env.component
This commit
This is used on
make *test*in order not to overwrite localconfiguration values.