This repository has been archived by the owner on Jan 9, 2025. It is now read-only.
ci(workflows): use latest tag for ray #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donch1989
reviewed
Feb 29, 2024
| @@ -385,13 +385,13 @@ jobs: | |||
| make build-latest | |||
| ITMODE_ENABLED=true \ | |||
| TRITON_CONDA_ENV_PLATFORM=cpu \ | |||
| RAY_RELEASE_TAG=${RAY_SERVER_VERSION} \ | |||
| RAY_LATEST_TAG=latest \ | |||
There was a problem hiding this comment.
look so, in Makefile and integration-test workflow, any console related test are running with latest backend services
donch1989
pushed a commit
that referenced
this pull request
Feb 29, 2024
Because - we are using `make latest` for `model` in console test This commit - use `RAY_LATEST_TAG=latest` for `Ray` image
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
make latestformodelin console testThis commit
RAY_LATEST_TAG=latestforRayimage