Skip to content
This repository has been archived by the owner on Jan 9, 2025. It is now read-only.

fix(text): bug about table judgement in markdown chunking #367

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix(text): bug about table judgement in markdown chunking #367

merged 1 commit into from
Sep 24, 2024

Conversation

chuang8511
Copy link
Contributor

@chuang8511 chuang8511 commented Sep 24, 2024 •
edited
Loading

Because

  • there is a bug when targeting table

This commit

  • fix the bug about table judgement

@linear Linear
Copy link

linear bot commented Sep 24, 2024

INS-5847 [Feat.] Replace langchaingo textsplitter package for open-source users

@chuang8511 chuang8511 marked this pull request as draft September 24, 2024 13:14
@chuang8511
feat(text): fix judgement of table
43c9855 
fix(text): fix judgement of table

chore: revert the function
@chuang8511 chuang8511 marked this pull request as ready for review September 24, 2024 14:42
@chuang8511 chuang8511 changed the title feat(text): expose function for sdk users fix(text): bug about table judgement in markdown chunking Sep 24, 2024
@chuang8511 chuang8511 merged commit 1ab13e2 into main Sep 24, 2024
10 checks passed
@chuang8511 chuang8511 deleted the chunhao/ins-5847 branch September 24, 2024 14:49
@droplet-bot droplet-bot mentioned this pull request Sep 24, 2024
Merged
donch1989 pushed a commit that referenced this pull request Sep 30, 2024
@droplet-bot
chore(main): release 0.29.0-beta (#365)
b321ed3 
🤖 I have created a release *beep* *boop*
---


##
[0.29.0-beta](v0.28.0-beta...v0.29.0-beta)
(2024-09-27)


### Features

* **compogen:** add table css and update doc
([#370](#370))
([c59b167](c59b167))
* **document:** improve image extraction from pdf
([#372](#372))
([39cdb2c](39cdb2c))
* **openai:** use batch inference for embedding
([#375](#375))
([cc897af](cc897af))


### Bug Fixes

* **compogen:** fix json format
([#364](#364))
([e6619ce](e6619ce))
* **text:** bug about table judgement in markdown chunking
([#367](#367))
([1ab13e2](1ab13e2))
* the input validator can not validate array format
([#379](#379))
([38074c8](38074c8))
* **web:** fix bugs and improve the performance
([#377](#377))
([f0f4f89](f0f4f89))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@donch1989 donch1989 Awaiting requested review from donch1989 donch1989 is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

@jvallesm jvallesm Awaiting requested review from jvallesm jvallesm is a code owner

Assignees
No one assigned
Labels
instill component
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chuang8511 @droplet-bot