This repository has been archived by the owner on Jan 9, 2025. It is now read-only.
feat: use error type for component definition not found error #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When clients (i.e. `pipeline-backend`) fetch a component definition and get an error, they need to discern internal errors from not found ones. By returning an error type instead of just a message, they can check the type to perform this assertion.
donch1989
pushed a commit
that referenced
this pull request
Aug 29, 2024
🤖 I have created a release *beep* *boop* --- ## [0.26.0-beta](v0.25.0-beta...v0.26.0-beta) (2024-08-29) ### Features * add milvus component ([#299](#299)) ([a48c211](a48c211)) * add zilliz component ([#297](#297)) ([92726ef](92726ef)) * **artifact:** improve artifact component ([#289](#289)) ([44ea196](44ea196)) * **document:** improve document operator ([#287](#287)) ([c0d8d31](c0d8d31)) * **hubspot:** add 4 tasks and modify Retrieve Association task and Get Thread task ([#265](#265)) ([62903ec](62903ec)) * introduce interfaces InputReader and OutputWriter ([#294](#294)) ([e26ecef](e26ecef)) * **jira:** add action tasks ([#241](#241)) ([e756e31](e756e31)) * make the API key be optional for Instill-Credit-supported component ([#305](#305)) ([0f9a7b2](0f9a7b2)) * **openai:** revert go-openai and add support for streaming ([#301](#301)) ([aa605fa](aa605fa)) * **openai:** use go-openai client ([#295](#295)) ([aa20a16](aa20a16)) * **sql:** add ssl/tls input as base64 encoded and move engine to setup ([#282](#282)) ([390e2b8](390e2b8)) * use error type for component definition not found error ([#302](#302)) ([cfcee78](cfcee78)) * **web:** improve web operator ([#292](#292)) ([1da84af](1da84af)) ### Bug Fixes * **document:** catch the error if there is no data in sheet ([#296](#296)) ([21bebbd](21bebbd)) * **hubspot:** fix test code ([#298](#298)) ([98c4261](98c4261)) * **text:** fix chunk position bugs ([#307](#307)) ([cfc9076](cfc9076)) * **text:** fix the bug if there are 2 exact same chunks ([#308](#308)) ([b58909f](b58909f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
pipeline-backend) need to discern not found errors from othererrors when fetching a component definition.
This commit
to detect the not found scenario.