Prometheus metrics #1498
Merged
Prometheus metrics #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waj
suggested changes
Aug 22, 2019
lib/ask/runtime/nuntium_channel.ex
Outdated
| |> Nuntium.Client.send_ao(channel.settings["nuntium_account"], messages) | ||
|
|
||
| SurvedaMetrics.increment_counter_with_label(:surveda_nuntium_enqueue, [elem(response, 0)]) |
There was a problem hiding this comment.
This will label the status with "ok" or "error" instead of the HTTP status code from Nuntium
lib/ask/runtime/verboice_channel.ex
Outdated
| {:ok, %{"state" => "expired"}} -> false | ||
| {:ok, %{"state" => _}} -> true | ||
| {:ok, %{"state" => _}} -> | ||
| SurvedaMetrics.increment_counter_with_label(:surveda_verboice_enqueue, [elem(response, 0)]) |
There was a problem hiding this comment.
This is not where a call is enqueued in Verboice. Move this to the setup function.
web/models/RespondentStatsMetrics.ex
Outdated
| alias Ask.Repo | ||
|
|
||
| def collect_mf(_registry, callback) do | ||
| respondent_stats_query = "select rs.* from respondent_stats rs" |
There was a problem hiding this comment.
Why not use RespondentStats model?
| |> Enum.zip(row) | ||
| |> Enum.into([]) | ||
| end) | ||
| callback.(create_gauge( |
There was a problem hiding this comment.
This is not generating the gauge with the right shape. The count value from the table should be used as the value for each set of labels.
Also I'd not "reflect" on the columns. The mode column currently stores a JSON with an array of strings. Let's convert that into a comma separated string for the mode label in the gauge.
web/models/RespondentStatsMetrics.ex
Outdated
| Prometheus.Model.create_mf(name, help, :gauge, __MODULE__, data) | ||
| end | ||
|
|
||
| defp formatRow(row) do |
…e RespondentStats model and correct formatting of metrics, moved verboice and nuntium enqueue metrics to each client accordingly to get the request status code
waj
approved these changes
Aug 28, 2019
This was referenced Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes and files for #1472