Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single Select - Editing in UI Bug #875

Closed
steesdale opened this issue Sep 21, 2016 · 1 comment
Closed

Single Select - Editing in UI Bug #875

steesdale opened this issue Sep 21, 2016 · 1 comment
Assignees
@matiasgarciaisaia
Labels
bug normal verified
Milestone
Release 2.2

Comments

@steesdale
Copy link

steesdale commented Sep 21, 2016 •
edited
Loading

You can edit information inside a textbox field without pressing "edit site", but cannot select from a dropdown field unless you first press "edit site".

I would expect that you could edit details for dropdown w/o going to edit site.
@steesdale steesdale changed the title Site Editing Bug Single Select - Editing in UI Bug Nov 9, 2016
matiasgarciaisaia added a commit that referenced this issue Mar 8, 2017
@matiasgarciaisaia
'Select one' fields in single-edit mode
e57bcf5 
The `notifyEdit` handler has been added in 2d7ba16
to correctly activate single-edition mode while clicking on the
field's rows. But that handler was preventing the click event to
reach the `<select>` element, and thus avoided showing the options
- ie, it couldn't be edited.

Removing the listener seems to fix the Select one edition, and it
doesn't seem to break the row-click for any of the existent field
types.

Fixes #875
@nditada nditada added this to the Release 2.2 milestone Apr 4, 2017
@matiasgarciaisaia matiasgarciaisaia self-assigned this Apr 18, 2017
@mmuller
Copy link
Contributor

mmuller commented May 23, 2017

Working properly in version da54b36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matiasgarciaisaia matiasgarciaisaia

Labels
bug normal verified
Projects
None yet
Milestone
Release 2.2
Development

No branches or pull requests
4 participants
@mmuller @nditada @steesdale @matiasgarciaisaia