Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: capture headers #689

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix: capture headers #689

merged 1 commit into from
Jan 20, 2025

Conversation

GSVarsha
Copy link
Contributor

bug

2025-01-20 20:18:39,760: 71181 DEBUG instana: Agent is ready.  Getting to work.
2025-01-20 20:19:09,467: 71181 DEBUG instana: Flask(blinker): Applying flask before/after instrumentation funcs
2025-01-20 20:19:09,469: 71181 DEBUG instana: extract_custom_headers: 
Traceback (most recent call last):
  File "/Users/varsha/Documents/GitHub/tracer-repos/python-sensor-example-flask/.venv/lib/python3.9/site-packages/instana/util/traceutils.py", line 18, in extract_custom_headers
    for custom_header in agent.options.extra_http_headers:
TypeError: 'NoneType' object is not iterable
127.0.0.1 - - [20/Jan/2025 20:19:09] "GET / HTTP/1.1" 200 -
2025-01-20 20:19:09,747: 71181 DEBUG instana: Reporting 1 spans

fix

2025-01-20 20:43:04,924: 76086 DEBUG instana: Agent is ready.  Getting to work.
2025-01-20 20:43:05,963: 76086 DEBUG instana: Flask(blinker): Applying flask before/after instrumentation funcs
127.0.0.1 - - [20/Jan/2025 20:43:05] "GET / HTTP/1.1" 200 -
2025-01-20 20:43:06,909: 76086 DEBUG instana: Reporting 1 spans

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha added this to the H1-2025 milestone Jan 20, 2025
@GSVarsha GSVarsha self-assigned this Jan 20, 2025
@GSVarsha GSVarsha requested a review from a team as a code owner January 20, 2025 15:20
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@GSVarsha GSVarsha merged commit 773e129 into main Jan 20, 2025
12 of 14 checks passed
@GSVarsha GSVarsha deleted the capture-header-fix branch January 20, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants