Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not pull container images from Docker Hub #670

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Not pull container images from Docker Hub #670

merged 4 commits into from
Nov 21, 2024

Conversation

pvital
Copy link
Member

@pvital pvital commented Nov 11, 2024 •
edited
Loading

This PR:

  1. Remove the Couchbase tests from the CI pipeline and
  2. Change the development files and CI configuration to stop pulling container images from the Docker Hub.

@pvital pvital added enhancement wip work in progress labels Nov 11, 2024
@pvital pvital self-assigned this Nov 11, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@pvital pvital force-pushed the not_pull_from_docker_hub branch 6 times, most recently from bf5fdd3 to 8f97073 Compare November 12, 2024 15:32
@pvital
chore: Not pulling container images from Docker Hub.
b8b7158 
Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
ci: Remove Couchbase from CI Pipeline.
9226f3a 
Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
ci: Update CircleCI config ...
fd57b0f 
to not pull container images from Docker Hub.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital pvital force-pushed the not_pull_from_docker_hub branch from 8f97073 to fd57b0f Compare November 19, 2024 14:13
@pvital
ci: Update Tekton config ...
18fe0b2 
to not pull container images from Docker Hub.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital pvital marked this pull request as ready for review November 19, 2024 18:15
@pvital pvital requested a review from a team as a code owner November 19, 2024 18:15
arjun-rajappa
arjun-rajappa approved these changes Nov 20, 2024
View reviewed changes
Copy link

@arjun-rajappa arjun-rajappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pvital pvital removed the wip work in progress label Nov 21, 2024
@pvital pvital merged commit 8721c8d into main Nov 21, 2024
12 of 13 checks passed
@pvital pvital deleted the not_pull_from_docker_hub branch November 21, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjun-rajappa arjun-rajappa arjun-rajappa approved these changes

Assignees

@pvital pvital

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pvital @arjun-rajappa