Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lambda publish script #668

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Update lambda publish script #668

merged 2 commits into from
Nov 6, 2024

Conversation

GSVarsha
Copy link
Contributor

@GSVarsha GSVarsha commented Nov 6, 2024

  • fix: add new aws region ap-southeast-5 to publish
  • style: Migrate from old-style %s to f-strings

@GSVarsha
fix: add new aws region ap-southeast-5 to publish
148bdc2 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha
style: Migrate from old-style "%s" to f-strings
b778440 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha added this to the H2-2024 milestone Nov 6, 2024
@GSVarsha GSVarsha self-assigned this Nov 6, 2024
@GSVarsha GSVarsha marked this pull request as ready for review November 6, 2024 09:31
@GSVarsha GSVarsha requested a review from a team as a code owner November 6, 2024 09:31
CagriYonca
CagriYonca approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@CagriYonca CagriYonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pvital
pvital approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@GSVarsha GSVarsha merged commit 3237273 into main Nov 6, 2024
13 of 14 checks passed
@GSVarsha GSVarsha deleted the update-lambda-publish-script branch November 6, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvital pvital pvital approved these changes

@CagriYonca CagriYonca CagriYonca approved these changes

Assignees

@GSVarsha GSVarsha

Labels
enhancement Review & Merge
Projects
None yet
Milestone
H2-2024
Development

Successfully merging this pull request may close these issues.
3 participants
@GSVarsha @pvital @CagriYonca