-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: Combine all requirements into single file #651
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few requests and comments.
1eb183d
to
d652160
Compare
Signed-off-by: Cagri Yonca <cagri@ibm.com>
d652160
to
b4a9ee6
Compare
e49a5eb
to
8af3d08
Compare
Signed-off-by: Cagri Yonca <cagri@ibm.com>
8af3d08
to
ded1ac2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
Combined all requirements into a single file, and added python version conditions.