Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Combine all requirements into single file #651

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

CagriYonca
Copy link
Contributor

Combined all requirements into a single file, and added python version conditions.

@CagriYonca CagriYonca requested review from pvital and GSVarsha October 15, 2024 14:00
@CagriYonca CagriYonca self-assigned this Oct 15, 2024
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few requests and comments.

@instana instana deleted a comment from github-actions bot Oct 22, 2024
@CagriYonca CagriYonca force-pushed the fix_requirements branch 15 times, most recently from e49a5eb to 8af3d08 Compare October 23, 2024 11:00
Signed-off-by: Cagri Yonca <cagri@ibm.com>
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@CagriYonca CagriYonca merged commit b7d66d1 into master Oct 24, 2024
12 of 13 checks passed
@CagriYonca CagriYonca deleted the fix_requirements branch October 24, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants