Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove an unsupported top level span attribute. #630

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

GSVarsha
Copy link
Contributor

@GSVarsha GSVarsha commented Sep 25, 2024

Related to #612.

  • Update the respective tests.

@GSVarsha GSVarsha force-pushed the remove_unsupported_span_field branch from 41f2c58 to 29fa741 Compare September 25, 2024 10:40
- Removed the span field "l" (which stores the span level) from the Span data since the Instana Backend does not support it.

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha force-pushed the remove_unsupported_span_field branch from 29fa741 to 1517386 Compare September 25, 2024 10:54
@GSVarsha GSVarsha added this to the H2-2024 milestone Sep 25, 2024
@GSVarsha GSVarsha self-assigned this Sep 25, 2024
@GSVarsha GSVarsha added Review & Merge OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry labels Sep 25, 2024
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@pvital pvital merged commit 3bbecc8 into otel_migration Sep 25, 2024
6 of 8 checks passed
@pvital pvital deleted the remove_unsupported_span_field branch September 25, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry Review & Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants