Skip to content

Commit

Permalink
fix(currency): run only starlette tests in gevent_starlette task
Browse files Browse the repository at this point in the history
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
  • Loading branch information
GSVarsha committed Oct 28, 2024
1 parent 288029b commit aab2062
Show file tree
Hide file tree
Showing 4 changed files with 27 additions and 24 deletions.
10 changes: 6 additions & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -327,8 +327,10 @@ jobs:
- pip-install-deps:
requirements: "tests/requirements-gevent-starlette.txt"
- run-tests-with-coverage-report:
gevent: "true"
tests: "tests/frameworks/test_gevent.py tests/frameworks/test_starlette.py"
# TODO: uncomment once gevent instrumentation is done
# gevent: "true"
# tests: "tests/frameworks/test_gevent.py tests/frameworks/test_starlette.py"
tests: "tests/frameworks/test_starlette.py"
- store-pytest-results
- store-coverage-report

Expand All @@ -344,7 +346,7 @@ workflows:
- python313
- py39cassandra
- py39couchbase
# - py39gevent_starlette
- py39gevent_starlette
- py312aws
- final_job:
requires:
Expand All @@ -356,5 +358,5 @@ workflows:
- python313
- py39cassandra
- py39couchbase
# - py39gevent_starlette
- py39gevent_starlette
- py312aws
29 changes: 14 additions & 15 deletions .tekton/pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -70,21 +70,20 @@ spec:
workspaces:
- name: task-pvc
workspace: python-tracer-ci-pipeline-pvc
# TODO: uncomment after gevent instrumentation is complete
# - name: unittest-gevent-starlette
# runAfter:
# - clone
# matrix:
# params:
# - name: imageDigest
# value:
# # 3.9.20-bookworm
# - "sha256:dbb0be5b67aa84b9e3e4f325c7844ab439f40a5cca717c5b24e671cfb41dbb46"
# taskRef:
# name: python-tracer-unittest-gevent-starlette-task
# workspaces:
# - name: task-pvc
# workspace: python-tracer-ci-pipeline-pvc
- name: unittest-gevent-starlette
runAfter:
- clone
matrix:
params:
- name: imageDigest
value:
# 3.9.20-bookworm
- "sha256:dbb0be5b67aa84b9e3e4f325c7844ab439f40a5cca717c5b24e671cfb41dbb46"
taskRef:
name: python-tracer-unittest-gevent-starlette-task
workspaces:
- name: task-pvc
workspace: python-tracer-ci-pipeline-pvc
- name: unittest-aws
runAfter:
- clone
Expand Down
6 changes: 4 additions & 2 deletions .tekton/run_unittests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,10 @@ couchbase)
export COUCHBASE_TEST='true' ;;
gevent_starlette)
export REQUIREMENTS='requirements-gevent-starlette.txt'
export TESTS=('tests/frameworks/test_gevent.py' 'tests/frameworks/test_starlette.py')
export GEVENT_STARLETTE_TEST='true' ;;
# TODO: uncomment once gevent instrumentation is done
# export TESTS=('tests/frameworks/test_gevent.py' 'tests/frameworks/test_starlette.py')
# export GEVENT_STARLETTE_TEST='true' ;;
export TESTS=('tests/frameworks/test_starlette.py');;
aws)
export REQUIREMENTS='requirements.txt'
export TESTS=('tests_aws') ;;
Expand Down
6 changes: 3 additions & 3 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@
if not os.environ.get("COUCHBASE_TEST"):
collect_ignore_glob.append("*test_couchbase*")

# if not os.environ.get("GEVENT_STARLETTE_TEST"):
# collect_ignore_glob.append("*test_gevent*")
# collect_ignore_glob.append("*test_starlette*")
if not os.environ.get("GEVENT_STARLETTE_TEST"):
collect_ignore_glob.append("*test_gevent*")
collect_ignore_glob.append("*test_starlette*")


if sys.version_info >= (3, 13):
Expand Down

0 comments on commit aab2062

Please sign in to comment.